Skip to content
Prev 470 / 21307 Next

[Bioc-devel] Biobase / eSet changes for this release

Hi Rafa,

I'm going to answer out of order...

Rafael A Irizarry <ririzarr at jhsph.edu> writes:
I think we should define an EmptyMatrix class:

    setClass("EmptyMatrix", contains="matrix")

Why?  Because:

 * new("EmptyMatrix") is small (no elements) 
 * We can dispatch on it.  I think we might be able to get some
   propagation of empty similar to how NA works.  This can keep the
   code from having to do lots of explicit type checking.
 * NULL can happen by accident and should be an error.  EmptyMatrix
   won't just "appear" from a calculation.
 * It will also mean that these values could go in a proper slot of
   type "matrix" without having to create the matrixOrNull class
   union.
There is something to be said for reserving the general class names
for things that will be general.  Perhaps it makes sense to choose a
slightly more specific name while sorting out the all-purpose use
cases.

Your RafaSnpSet can become SnpSet.  But if you start with SnpSet and
go off in a direction that is not useful to others, then there is no
easy fix.



+ seth