Skip to content
Prev 16022 / 21312 Next

[Bioc-devel] DeMixT issue

Hi Peng,

I was looking through your version bumps, and it looks a little off-track I have to say. The version bumps you should have in your repository should be following the order(from the commit below) should be 1.3.0 --> 1.3.1 --> 1.3.2 and so on.

commit c358f5e7d8564423fb60abea7024b01068046ea8
Author: Nitesh Turaga <nitesh.turaga at gmail.com>?
Date:   2019-10-29 13:43:32 -0400?
?
    bump x.y.z version to odd y after creation of RELEASE_3_10 branch?
?
diff --git a/DESCRIPTION b/DESCRIPTION?
index c922ad7..8fff467 100644?
--- a/DESCRIPTION?
+++ b/DESCRIPTION?
@@ -2,7 +2,7 @@ Package: DeMixT?
 Title: Cell type-specific deconvolution of heterogeneous tumor samples with?
         two or three components using expression data from RNAseq?
         or microarray platforms?
-Version: 1.2.0?
+Version: 1.3.0


But it seems like this order has been lost somehow and you started with 1.4.0 and 1.5.0. I'm actually surprised you were able to push up these changes to the repository as the git hook should have prevented you from making 1.3.0 --> 1.4.0. An important question is, did you "push"  your commits to the Bioconductor git repository after accumulating multiple commits on your local machine?

This commit should have been declined by the hook,

commit c17654aa8f76e36faf143deedf0495619567459a
Author: pengyang0411 <pengyang0411 at gmail.com>?
Date:   Sun Jan 12 22:26:37 2020 -0600?
?
    update to v1.4.0?
?
diff --git a/DESCRIPTION b/DESCRIPTION?
index 62a7290..9b5a6b8 100644?
--- a/DESCRIPTION?
+++ b/DESCRIPTION?
@@ -1,7 +1,7 @@?
 Package: DeMixT?
 Title: Cell type-specific deconvolution of heterogeneous tumor samples with two or three?
        components using expression data from RNAseq or microarray platforms?
-Version: 1.3.0?
+Version: 1.4.0?
 Date: 2020-01-06

And you have this  commit(7fa3d1b4e97a48112634452ac752a9fed8ade493) taking it to  1.5.0 and then this one (f5c7fdc25ed18dc21f16f02bdc20a1805efa2b50) to  1.5.1.

We'll have to figure out a way to fix your version numbers. But as far as the build report goes, if you pushed all your commits in today, then you'll have to wait for the nightly builders to produce the build report tomorrow.

We'll get back to you on a path forward.

Best,

Nitesh