On Thu, Oct 15, 2015 at 11:04 PM, Herv? Pag?s <hpages at fredhutch.org>
wrote:
Hi Michael,
On 10/15/2015 10:08 AM, Michael Lawrence wrote:
Tangentially related, it seems like nchar is worth defining in
BiocGenerics, with a signature of "x". I saw that Biostrings uses
The 2 "nchar" methods that dispatch on the 'type' argument are from
the Biostrings 1 era (> 9 years old) and were kept in the
Biostrings/Biostrings1/ folder for legacy only (this code doesn't
get evaluated, not even installed). That reminds me that it's probably
time to get rid of all that stuff.
But if we're just going to use the signature of 'x',
I can make nchar dispatch internally, so we don't need an R-level
If by "make nchar dispatch internally" you mean "turn nchar() into a
primitive in R", like, say, length(), names(), dim(), dimnames(), `[`,
etc... then works for me.
Essentially, yes. I've modified the methods package to support internal
dispatch within .Internal() calls. So no need to make it a primitive. Will
move ahead, thanks.
Michael
On Thu, Oct 15, 2015 at 5:19 AM, Morgan, Martin <
Martin.Morgan at roswellpark.org> wrote:
-----Original Message-----
From: Bioc-devel [mailto:bioc-devel-bounces at r-project.org] On Behalf
Marcin Cieslik
Sent: Thursday, October 15, 2015 7:46 AM
To: bioc-devel at r-project.org
Subject: [Bioc-devel] SV4Vectors installation problem
Dear Bioconductors,
Somewhere in August S4Vectors stopped installing correctly resulting
Creating a generic function for ?nchar? from package ?base? in package
?S4Vectors?
message (that cannot be suppressed) each time the package is loaded.
issue is not fixed by a fresh reinstall of bioconductor. The first
of the
you're right that this is a message and that it cannot be suppressed,
the package still functions correctly, right?
The problem was introduced by a change in R. The above is a
The permanent solution is now to use the current version of R (3.2.2)
Bioc (3.2). The specific commit was
------------------------------------------------------------------------
r106498 | mtmorgan at fhcrc.org | 2015-07-16 15:10:40 -0400 (Thu, 16 Jul
2015) | 5 lines
define nchar,Rle-method in .onLoad
- work-around consequences of changed base::nchar signature for
3.2.1 binary builds used in 3.2.0
------------------------------------------------------------------------
reproduces the problem.
Yours,
Marcin
[[alternative HTML version deleted]]