Skip to content

[Bioc-devel] Pandoc issues

4 messages · Hervé Pagès, Vladimir Kiselev

Original
Vladimir Kiselev
# 
Hi,

I am not able to plot Sankey diagrams using `googleVis` in the vignette of
my package (scmap). Here is error message:
http://bioconductor.org/checkResults/devel/bioc-LATEST/scmap/malbec2-buildsrc.html

It says:
pandoc: Could not fetch
https://www.google.com/jsapi?callback=displayChartSankeyID6c664210b0e5
TlsExceptionHostPort (HandshakeFailed Error_EOF) "www.google.com" 443

I had the same problem on my local machine before but updating pandoc to
the latest version and also installing the development version of
`rmarkdown` package solved the problem.

So at the moment most of the things from `googleVis` (
https://cran.r-project.org/web/packages/googleVis/vignettes/googleVis_examples.html)
fail if built in the package vignette.

Would it be possible to address this issue?
Many thanks,
Vlad
Hervé Pagès
# 
Hi Vladimir,

mmh... scmap::getSankey() used to work (and still works in the release
version of scmap) so I wonder what could have changed in the devel
version or in one of its dependencies to cause it to fail now...

Anyway we'll look into updating pandoc to the latest version (currently
at version 1.19.1 on the Linux build machines).

As for rmarkdown, it's a CRAN package and is currently at version 1.8
there:

   https://cran.r-project.org/web/packages/rmarkdown/index.html

That's the version installed on the build machines. Note that we only
install packages from CRAN or Bioconductor on these machines.

If you think you found a bug in rmarkdown 1.8, or if you need a
feature that is only available in the devel version of rmarkdown,
I would suggest that you contact the rmarkdown developers by opening
an issue on GitHub:

   https://github.com/rstudio/rmarkdown/issues

If the devel version of rmarkdown requires a higher version of pandoc
in order to work properly, then maybe you could suggest them to update
the SystemRequirements field, which is currently:

   SystemRequirements: pandoc (>= 1.12.3) - http://pandoc.org

(in both, rmarkdown 1.8 and 1.8.3)

Best,
H.
On 11/28/2017 07:12 AM, Vladimir Kiselev wrote:

  
    

      
      
    

  


  


      

    

    

      
      

        


  

        

      Vladimir Kiselev
    

    

      
      #
    

  


  

      
Hi Herve,

Thanks for your reply! scmap::getSankey() didn't really work in the
release, so I switched it off quite long ago by setting `eval = FALSE`.

Regarding rmarkdown: I remember when I updated Pandoc I got a different
error from rmarkdown, then I googled it and found that it was related to
the changes in the new version of Pandoc (I can't find the link now....).
The rmarkdown maintainer said he'd fixed it in the latest version which is
not the release version it. I have installed rmarkdown from github (at the
moment I have 1.8.3) and there was no error. They probably forgot to update
SystemRequirements.

So, I suppose updating Pandoc on your side won't solve the problem
completely and we will need to wait until the new version of rmarkdown is
pushed to CRAN. At the moment I can probably switch Sankey diagrams off in
my vignette. The problem is I have just significantly updated it and these
diagrams are quite important now.

Cheers,
Vlad

        
On Tue, Nov 28, 2017 at 6:11 PM Herv? Pag?s <hpages at fredhutch.org> wrote:

        

            

      
      
      
    

  
    

      
      
    

  


  


      

    

    

      
      

        


  

        

      Hervé Pagès
    

    

      
      #
    

  


  

      
Hi Vladimir,

        
On 11/28/2017 01:25 PM, Vladimir Kiselev wrote:

            

      
      
      
    

        
Wouldn't hurt to remind them about this.

            

      
      
      
    

        
Probably worth asking the rmarkdown folks whether they're planning
to upload version 1.8.3 to CRAN soon, and to decide whether to switch
off the diagrams or not based on what they say. Once rmarkdown 1.8.3
(or higher) is on CRAN, I suggest that you update your Depends
field to depend on rmarkdown >= 1.8.3. This will ensure that your
users can also use scmap::getSankey(), not just our build machines.

Note that if these diagrams are important, then you will probably need
to consider porting your fixes to release. Your regular users use
release, not devel.

Best,
H.