Skip to content

[Bioc-devel] svn commit fails

4 messages · J.J.Goeman at lumc.nl, James W. MacDonald, Hervé Pagès

Original
J.J.Goeman at lumc.nl
# 
Dear all,

When I try to commit my package to
https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/globaltest,
it fails with the following not-so-informative error message. I have no
clue where to look for a source of this problem. Does anybody have a
suggestion?


Modified: M:\R\packages\globaltest\DESCRIPTION  
Modified: M:\R\packages\globaltest\R\globaltest.R  
Modified: M:\R\packages\globaltest\R\internal.R  
Modified: M:\R\packages\globaltest\changelog.txt  
Sending content: M:\R\packages\globaltest\R\globaltest.R  
Sending content: M:\R\packages\globaltest\DESCRIPTION  
Sending content: M:\R\packages\globaltest\changelog.txt  
Sending content: M:\R\packages\globaltest\R\internal.R  
Error: Commit failed (details follow):  
Error: 'pre-commit' hook failed with error output:  
Finished!:   

svn update seems to work without problems.

I'm using win XP with

TortoiseSVN 1.5.6, Build 14908 - 32 Bit , 2008/12/20 11:51:04
Subversion 1.5.5, 
apr 1.2.12
apr-utils 1.2.12
berkeley db 4.4.20
neon 0.28.3
OpenSSL 0.9.8i 15 Sep 2008
zlib 1.2.3

Best regards,

Jelle

www.msbi.nl/goeman
J.J.Goeman at lumc.nl
# 
Dear developers,

Holger Schwender suggested to add a comment to the svn. This seems to be
the solution.

Are comments obligatory for commits?

Kind regards,

Jelle
James W. MacDonald
# 
I was under the impression that they were - or at least the impression 
of one using svn commit -m "".

However, do note that your commit messages end up in the changelog with 
the intent that this information might be useful to people who either 
use or depend on your package, so incomprehensible and/or missing commit 
messages are both less than useful (and will not be useful to you in the 
future either, unless you have an eidetic memory and have no need for 
such crutches).

Best,

Jim
J.J.Goeman at lumc.nl wrote:

  
    

      
      
    

  


  


      

    

    
2 days later

    

      
      

        


  

        

      Hervé Pagès
    

    

      
      #
    

  


  

      
Hi Jelle,

We've added a pre-commit hook to our svn repo a few weeks ago which
purpose was to prevent developers from committing files that differ
only in case. See the announcement here:

   https://stat.ethz.ch/pipermail/bioc-devel/2009-January/001770.html

It seems that this new setup is also enforcing comments for commits.
That was not intended. In fact I was not aware of this new behaviour
until I saw your post.

Just FYI the pre-commit script we are using is check-case-insensitive.pl
from:

   http://svn.collab.net/repos/svn/branches/1.4.x/contrib/hook-scripts/

When we installed this script on our svn server, we also inadvertendly
activated some code that make sure that the log message contains some
text. Since this is indeed considered good practice, let's keep it for
now (unless there is some strong disagreement about it).

I added an informative error message so now you will get:

   Transmitting file data .svn: Commit failed (details follow):
   svn: MERGE request failed on '/bioconductor/trunk/madman/Rpacks/Biostrings'
   svn: 'pre-commit' hook failed with error output:

     Please comment your commit. Thanks!

       The Biocore Team

Cheers,

H.

        
J.J.Goeman at lumc.nl wrote: