Skip to content

[Bioc-devel] mzR build failure on Windows: missing HDF5 libraries

7 messages · Martin Morgan, Mike Smith, Rainer Johannes +1 more

#
Dear BioC team,

a happy new year to you as well ;-)

for a while we have a build error for mzR on windows
due to missing HDF5 libs:
https://github.com/sneumann/mzR/issues/143

I am looking for some hints how to fix this.
The https://bioconductor.org/packages/release/bioc/html/rhdf5.html
package has embedded rhdf5/src/libwin/x64/libhdf5ForBioC-7.dll
which we could try to use (It does not yet contain H5Cpp.h,
and we'd have to ask Bernd Fischer et al to include it.

ALternatively, it might already be present on the build machines, 
but we didn't have the include path set up:
https://github.com/r-hub/rhub/issues/91
"... the location of the hdf5 libraries is defined as
${LIB_HDF5}/lib${R_ARCH}. "

So, any hints which way to go for a fix ?

Yours,
Steffen
#
On 01/02/2018 03:16 PM, Neumann, Steffen wrote:
Not a comprehensive answer or solution to release, but in devel there is 
Rhdf5lib which contains both the C and C++ headers. (I believe that 
rhdf5 will move to using this library in the near future) Martin
This email message may contain legally privileged and/or...{{dropped:2}}
#
Rhdf5lib is in the release branch too.  I'm happy to help try and get mzR
working with it.

On 2 January 2018 at 21:31, Martin Morgan <martin.morgan at roswellpark.org>
wrote:

  
  
2 days later
#
Would be great, Steffen, to update mzR to use Rhdf5lib. I believe CRAN 
packages with mzR dependencies are also failing to build under devel, as 
well as xcms and other mzR dependencies in Bioc.

Martin
On 01/03/2018 04:18 AM, Mike Smith wrote:
This email message may contain legally privileged and/or...{{dropped:2}}
2 days later
#
Hi,

Following the bug report in 
https://github.com/sneumann/mzR/issues/143

there is a branch with a fix in 
https://github.com/sneumann/mzR/pull/144

that passes Travis in 
https://travis-ci.org/sneumann/mzR/builds/324960762

which we can merge once there is a bit more testing
on other platforms. Any takers ?

Yours,
Steffen
On Fri, 2018-01-05 at 10:55 -0500, Martin Morgan wrote:
#
I'll test on mac and windows

cheers, jo
3 days later
#
Hi, 

compiling and linking is fixed now on all architectures,
thanks to the Rhdf5lib team for fixing/changing Rhdf5lib 
to allow unmodified code to link against it, and to Juhannes 
for testing. 

Have a nice day,
yours,
Steffen
On Mon, 2018-01-08 at 05:21 +0000, Rainer Johannes wrote: