Skip to content

[Bioc-devel] Some build system changes

2 messages · Hervé Pagès, Seth Falcon

#
Hi Bioc-developers,


Yesterday I set up the build system to make it use the "-ansi" flag
when compiling Bioconductor devel packages. Today, after looking at
the build/check results, it seems that this change broke too many
packages :-(

2 frequent non-ANSI "features" found in the Bioconductor C code are:

   - Use of C++-style comments //

   - Use of the R_FINITE macro (defined in $R_HOME/src/include/Rmath.h):
     this macro is a wrapper for C99 isfinite() function. You must use
     the "-std=gnu99" gcc flag in order to compile code that uses it.

So may be it's better if we stick to the original flags and I will
restore them ASAP. Any suggestion?


H.
5 days later
#
Hi all,

I have a request...

Herve Pages <hpages at fhcrc.org> writes:
If your package has C code that uses C++-style comments, please change
them to C-style comments.  This will make your package code more
portable across a wider variety of compilers/platforms.

+ seth