[EXTERNAL] Re: issue with model.frame()

Unfortunately, I spoke too soon.

model.frame calls formula <- terms(formula, data = data) if formula does not inherit from class "terms" as in your case.

And that is where the bad terms.labels attribute comes from.

So, the fix I suggested won't work.

But maybe you can just supply a terms object to model.frame that has correct term.labels.

Chuck

On May 1, 2018, at 10:55 AM, Therneau, Terry M., Ph.D. via R-devel <r-devel at r-project.org> wrote:

Great catch.  I'm very reluctant to use my own model.frame, since that locks me into tracking all the base R changes, potentially breaking survival in a bad way if I miss one.