Skip to content
Back to formatted view

Raw Message

Message-ID: <l1b4rvchsjop8i9rjme6qcjtnh8mr3ola2@4ax.com>
Date: 2003-11-12T13:50:19Z
From: Duncan Murdoch
Subject: write.table quotes too much (PR#5042)
In-Reply-To: <16305.61823.637826.913353@mithrandir.hornik.net>

On Wed, 12 Nov 2003 09:38:23 +0100, you wrote:

>> The bug is due to the "else" near the beginning of write.table:
>
>>     if(!is.data.frame(x))
>>         x <- data.frame(x)
>>     else if(is.logical(quote) && quote)
>>         quote <- which(unlist(lapply(x, function(x)
>>                                     is.character(x) || is.factor(x))))
>
>> However, that looks intentional to me.  Is it really?
>
>Yes, but maybe not quite right :-)
>
>I think we could change this to remove the 'else', but pls check the
>consequences.

I've committed the change.  As far as I can tell, it doesn't have any
bad side effects.

Duncan Murdoch