Message-ID: <4B61ABEE.1000805@biostat.ku.dk>
Date: 2010-01-28T15:23:26Z
From: Peter Dalgaard
Subject: src/library/grid/src/grid.c (PR#14199)
In-Reply-To: <20100128115509.C88CB2831FEC@mail.pubhealth.ku.dk>
A.R.Runnalls at kent.ac.uk wrote:
> At around line 2590, in function gridRect() in
> src/library/grid/src/grid.c (at the latest svn revision, 50745), ought
> not temp, www and hhh to be PROTECTed within this block?
Plausible, provided that anything can allocate while those are being
used. Could you perhaps investigate that a little further? (Bug reports
should really contains exclamation points and not question marks...)
If unit() can allocate, then all constructs like
2565 www = unit(xadj, L_INCHES);
2566 hhh = unit(yadj, L_INCHES);
are equally dubious.
Oh, never mind, unit() definitely allocates, so of course you are right!
--
O__ ---- Peter Dalgaard ?ster Farimagsgade 5, Entr.B
c/ /'_ --- Dept. of Biostatistics PO Box 2099, 1014 Cph. K
(*) \(*) -- University of Copenhagen Denmark Ph: (+45) 35327918
~~~~~~~~~~ - (p.dalgaard at biostat.ku.dk) FAX: (+45) 35327907