Request to review a patch for rpart

Kirill,

Perhaps I'm just being obtuse, but what are you proposing rpart do in 
the case of an empty model?  Return a "tree" that always guesses the 
most common label, or doesn't guess at all (NA)? It doesn't seem like 
you'd need rpart for either of those.

~G


On Wed, Aug 13, 2014 at 3:51 AM, Kirill M?ller 
<kirill.mueller at ivt.baug.ethz.ch 
<mailto:kirill.mueller at ivt.baug.ethz.ch>> wrote:

    Dear list


    For my work, it would be helpful if rpart worked seamlessly with
    an empty model:

    library(rpart); rpart(formula=y~0, data=data.frame(y=factor(1:10)))

    Currently, an unrelated error (originating from na.rpart) is thrown.

    At some point in the near future, I'd like to release a package to
    CRAN which uses rpart and relies on that functionality. I have
    prepared a patch (minor modifications at three places, and a test)
    which I'd like to propose for inclusion in the next CRAN release
    of rpart. The patch can be reviewed at
    https://github.com/krlmlr/rpart/tree/empty-model, the files (based
    on the current CRAN release 4.1-8) can be downloaded from
    https://github.com/krlmlr/rpart/archive/empty-model.zip.

    Thanks for your attention.


    With kindest regards

    Kirill M?ller