R build fails during make when configured with "--with-x=no" (PR#13665)

jeet at ku.edu wrote:

If R is configured using the "--with=x=no" option, then the make  
fails with the
following error:

,,,,

make[1]: *** [R] Error 1
make[1]: Leaving directory `/home/jeet/Scratch/r-build/on-frontend/ 
R-2.9.0/src'
make: *** [R] Error 1

The problem appears to be with the "src/modules/Makefile".  
Specfically, lines
26-29:

	@for d in "$(R_MODULES)"; do \
	  (cd $${d} && $(MAKE) $@) || exit 1; \
	done

Here, R_MODULES is blank, resulting in the "cd" command  
transferring to the
user's home directory, where, of course, no Makefile is found  
resulting in the
error above.

(Even more "fun" would ensue if in fact there were a Makefile  
there...)

Work-around appears to be to simply disable loop if R_MODULES is  
empty.

Shell script and Make portability is a pain in the derriere, but
offhand, those double quotes just look wrong:

viggo:~/>for i in "" ; do echo $i; done

viggo:~/>for i in  ; do echo $i; done
viggo:~/>for i in "foo bar" ; do echo $i; done
foo bar
viggo:~/>for i in foo bar ; do echo $i; done
foo
bar

Notice that the versions with quotes invariably do the Wrong Thing....


-- 
  O__  ---- Peter Dalgaard             ?ster Farimagsgade 5, Entr.B
 c/ /'_ --- Dept. of Biostatistics     PO Box 2099, 1014 Cph. K
(*) \(*) -- University of Copenhagen   Denmark      Ph:  (+45)  
35327918
~~~~~~~~~~ - (p.dalgaard at biostat.ku.dk)              FAX: (+45)  
35327907