Raw Message

Message-ID: <20041028150131.073BE11350@slim.kubism.ku.dk>
Date: 2004-10-28T17:01:34Z
From: Jeffrey J. Hallman
Subject: Internal function isUME() in findGeneric() is wrong (PR#7320)

Full_Name: Jeff Hallman
Version: 2.0
OS: Linux
Submission from: (NULL) (132.200.32.34)


The function findGeneric() in the utils namespace contains this internal
function:

  isUME <- function(e) {
        if (is.call(e) && (is.name(e[[1]]) || is.character(e[[1]]))) {
            switch(as.character(e[[1]]), UseMethod = as.character(e[[2]]), 
                "{" = isUMEbrace(e), "if" = isUMEif(e), "")
        }
        else ""
    }

This fails if the generic called UseMethod() without an argument, which is
perfectly legal.  Changing it to this seems to work:

  isUME <- function(e) {
    if(is.call(e) &&(is.name(e[[1]]) || is.character(e[[1]]))) {
      switch(as.character(e[[1]]), 
             UseMethod = ifelse(length(e) == 1, fname, as.character(e[[2]])), 
             "{" = isUMEbrace(e),
             "if" = isUMEif(e),
             "")
    }
    else ""
  }


Jeff