Skip to content

small bug in panel.cor in example for pairs?

2 messages · Matthias Kohl, Martin Maechler

Matthias Kohl
# 
Dear all,

in the Example section of pairs there is
panel.cor <- function(x, y, digits=2, prefix="", cex.cor)
    {
         usr <- par("usr"); on.exit(par(usr))
         par(usr = c(0, 1, 0, 1))
         r <- abs(cor(x, y))
         txt <- format(c(r, 0.123456789), digits=digits)[1]
         txt <- paste(prefix, txt, sep="")
         if(missing(cex.cor)) cex <- 0.8/strwidth(txt)
         text(0.5, 0.5, txt, cex = cex * r)
     }

Shouldn't the last two lines read
         if(missing(cex.cor)) cex.cor <- 0.8/strwidth(txt)
         text(0.5, 0.5, txt, cex = cex.cor * r)
?

Best,
Matthias

--
Dr. Matthias Kohl
Mathematical Statistics
University of Bayreuth
3 days later
Martin Maechler
# 
MK> Dear all,
    MK> in the Example section of pairs there is
    MK> panel.cor <- function(x, y, digits=2, prefix="", cex.cor)
    MK> {
    MK> usr <- par("usr"); on.exit(par(usr))
    MK> par(usr = c(0, 1, 0, 1))
    MK> r <- abs(cor(x, y))
    MK> txt <- format(c(r, 0.123456789), digits=digits)[1]
    MK> txt <- paste(prefix, txt, sep="")
    MK> if(missing(cex.cor)) cex <- 0.8/strwidth(txt)
    MK> text(0.5, 0.5, txt, cex = cex * r)
    MK> }

    MK> Shouldn't the last two lines read
    MK> if(missing(cex.cor)) cex.cor <- 0.8/strwidth(txt)
    MK> text(0.5, 0.5, txt, cex = cex.cor * r)
    MK> ?

yes, indeed.
A rather inconsequential bug, but you are right; I've fixed 
(for R-devel).

Regards,
Martin

    MK> Best,
    MK> Matthias

    MK> --
    MK> Dr. Matthias Kohl
    MK> Mathematical Statistics
    MK> University of Bayreuth