7 messages · Dan Kelley, Hadley Wickham, Duncan Murdoch
This may be new to 2.9.0, but I'm not sure, since I no longer have the older version. I notice that R CMD check has no problem with .svn directories, but it dislikes .git directories. That seems a bit of a problem, for folks like me who sometimes use git. Perhaps this behaviour could be changed? Dan.
View this message in context: http://www.nabble.com/R-CMD-check-dislikes-.git-directories-tp23166614p23166614.html Sent from the R devel mailing list archive at Nabble.com.
This may be new to 2.9.0, but I'm not sure, since I no longer have the older version. I notice that R CMD check has no problem with .svn directories, but it dislikes .git directories. That seems a bit of a problem, for folks like me who sometimes use git. Perhaps this behaviour could be changed?
According to the R Extensions manual, it excludes dirs named CVS, .svn, .arch-ids, .bzr, and git. Is .git the right thing to exclude instead of git, or are both possible? The same section points out the workaround: use the .Rbuildignore file to say what isn't really part of your package. Duncan Murdoch
On 21/04/2009 7:59 PM, Dan Kelley wrote:
This may be new to 2.9.0, but I'm not sure, since I no longer have the older version. I notice that R CMD check has no problem with .svn directories, but it dislikes .git directories. That seems a bit of a problem, for folks like me who sometimes use git. Perhaps this behaviour could be changed?
According to the R Extensions manual, it excludes dirs named CVS, .svn, .arch-ids, .bzr, and git. Is .git the right thing to exclude instead of git, or are both possible?
Actually, that looks like a typo in the manual: the code excludes .git, not git. I'll fix the typo, but it means I don't know what error you're talking about. Could you post instructions for reproducing? Duncan Murdoch
The same section points out the workaround: use the .Rbuildignore file to say what isn't really part of your package. Duncan Murdoch
I think what I'm pasting below will illustrate. (The git repo is behind a firewall, so I can't invite folks to download the repo to test locally. I could tar up the source and put it on a website if that would help.) * checking if this is a source package ... OK * checking for executable files ... WARNING Found the following executable file(s): .git/objects/01/9002df908b9c97f98e6ad3dd079bee436a2d66 .git/objects/08/ac4fdd57a77afe2f8071c2e697cbda02b276b7 .git/objects/13/49be3ed32dd801eacbdf1cc96a7577dcdfa2d7 .git/objects/14/45d1188fcd949bd77d5c1117906c7987fe15a7 .git/objects/18/756ad87b639ad2123a0ac78d04daa613d16966
On 21/04/2009 8:10 PM, Duncan Murdoch wrote:
On 21/04/2009 7:59 PM, Dan Kelley wrote:
This may be new to 2.9.0, but I'm not sure, since I no longer have the older version. I notice that R CMD check has no problem with .svn directories, but it dislikes .git directories. That seems a bit of a problem, for folks like me who sometimes use git. Perhaps this behaviour could be changed?
According to the R Extensions manual, it excludes dirs named CVS, .svn, .arch-ids, .bzr, and git. Is .git the right thing to exclude instead of git, or are both possible?
Actually, that looks like a typo in the manual: the code excludes .git, not git. I'll fix the typo, but it means I don't know what error you're talking about. Could you post instructions for reproducing? Duncan Murdoch
The same section points out the workaround: use the .Rbuildignore file to say what isn't really part of your package. Duncan Murdoch
Dan Kelley, PhD Associate Professor and Graduate Coordinator Dept. Oceanography, Dalhousie University, Halifax NS B3H 4J1 kelley.dan at gmail.com (1-minute path) or Dan.Kelley at Dal.Ca (2-hour path) Phone 902 494 1694; Fax 902 494 3877
I think what I'm pasting below will illustrate. (The git repo is behind a firewall, so I can't invite folks to download the repo to test locally. I could tar up the source and put it on a website if that would help.) * checking if this is a source package ... OK * checking for executable files ... WARNING Found the following executable file(s): .git/objects/01/9002df908b9c97f98e6ad3dd079bee436a2d66 .git/objects/08/ac4fdd57a77afe2f8071c2e697cbda02b276b7 .git/objects/13/49be3ed32dd801eacbdf1cc96a7577dcdfa2d7 .git/objects/14/45d1188fcd949bd77d5c1117906c7987fe15a7 .git/objects/18/756ad87b639ad2123a0ac78d04daa613d16966
Okay, that helps. I don't think the problem is git versus svn, it's that you've got executable files in a directory where check shouldn't be looking. I don't think .Rbuildignore would help you. I'll pass this on as a bug... Duncan Murdoch
On 2009-04-21, at 9:24 PM, Duncan Murdoch wrote:
On 21/04/2009 8:10 PM, Duncan Murdoch wrote:
On 21/04/2009 7:59 PM, Dan Kelley wrote:
This may be new to 2.9.0, but I'm not sure, since I no longer have the older version. I notice that R CMD check has no problem with .svn directories, but it dislikes .git directories. That seems a bit of a problem, for folks like me who sometimes use git. Perhaps this behaviour could be changed?
According to the R Extensions manual, it excludes dirs named CVS, .svn, .arch-ids, .bzr, and git. Is .git the right thing to exclude instead of git, or are both possible?
Actually, that looks like a typo in the manual: the code excludes .git, not git. I'll fix the typo, but it means I don't know what error you're talking about. Could you post instructions for reproducing? Duncan Murdoch
The same section points out the workaround: use the .Rbuildignore file to say what isn't really part of your package. Duncan Murdoch
Dan Kelley, PhD Associate Professor and Graduate Coordinator Dept. Oceanography, Dalhousie University, Halifax NS B3H 4J1 kelley.dan at gmail.com (1-minute path) or Dan.Kelley at Dal.Ca (2-hour path) Phone 902 494 1694; Fax 902 494 3877
Okay, that helps. ?I don't think the problem is git versus svn, it's that you've got executable files in a directory where check shouldn't be looking. ?I don't think .Rbuildignore would help you. I'll pass this on as a bug...
I've complained about this in the past, and I was told that "good practice" was to run R CMD check on the file created by R CMD build. Hadley
Okay, that helps. I don't think the problem is git versus svn, it's that you've got executable files in a directory where check shouldn't be looking. I don't think .Rbuildignore would help you. I'll pass this on as a bug...
I've complained about this in the past, and I was told that "good practice" was to run R CMD check on the file created by R CMD build.
That's true, and it would solve the problem, which may be why it hasn't been a high enough priority to fix. I won't fix it: check is written in Perl, and I don't know Perl well enough to want to mess with it. But maybe a second complaint about it will motivate someone who does know Perl to put together a fix. Duncan Murdoch