Bug in 2.4.0 Windows menu setup (PR#9277)

I've tracked down where this is occurring, but I don't know how to fix
it.  Here's a summary:

If the language in Windows is set to simplified Chinese (i.e. Chinese
(PRC)) and message translations are installed, then on startup Rgui
crashes when it tries to install the console popup menu.  The crash
comes when it gets an error trying to do a conversion using mbrtowc, and
tries to report it using error(); but the R symbol table is needed for
that, and it hasn't been set up yet.

I'm not sure which menu entry causes the crash, but I think it's not the
first, so conceivably this is caused by an error in one of the
translation files.  Indeed, setting the language to Chinese (Taiwan) works.

I don't know how to debug the translation files, so I'm going to have to
leave this one for now.  I think Brian Ripley is the only one who
understands all the details of what goes on in the translations, and
he's away until Oct 9.

Duncan Murdoch

On 10/3/2006 9:00 PM, ronggui wrote:

This morning I downloaded R-2.4.0 and install in under Windows. I customized
the installation and choose "Message translations",but I could not launch
Rgui.exe successfully( Rterm.exe worked fine). If I did't choose "Message
translations", Rgui.exe worked fine.

"Message translations" is Simplified Chinese.

version

               _
platform       i386-pc-mingw32
arch           i386
os             mingw32
system         i386, mingw32
status
major          2
minor          4.0
year           2006
month          10
day            03
svn rev        39566
language       R
version.string R version 2.4.0 (2006-10-03)




------------------------------------------------------------------------

I do not understand Chinese, but recognize kanji.
RGui-zh_CN.po is written in utf-8, but charset=CP936 wrote.

  perl -p -i -e 's#charset=CP936#charset=utf-8#' RGui-zh_CN.po
  msgfmt -o RGui.mo RGui-zh_CN.po

2006/10/5, murdoch at stats.uwo.ca <murdoch at stats.uwo.ca>:

I've tracked down where this is occurring, but I don't know how to fix
it.  Here's a summary:

If the language in Windows is set to simplified Chinese (i.e. Chinese
(PRC)) and message translations are installed, then on startup Rgui
crashes when it tries to install the console popup menu.  The crash
comes when it gets an error trying to do a conversion using mbrtowc, and
tries to report it using error(); but the R symbol table is needed for
that, and it hasn't been set up yet.

I'm not sure which menu entry causes the crash, but I think it's not the
first, so conceivably this is caused by an error in one of the
translation files.  Indeed, setting the language to Chinese (Taiwan) works.

I don't know how to debug the translation files, so I'm going to have to
leave this one for now.  I think Brian Ripley is the only one who
understands all the details of what goes on in the translations, and
he's away until Oct 9.

Duncan Murdoch

On 10/3/2006 9:00 PM, ronggui wrote:

This morning I downloaded R-2.4.0 and install in under Windows. I customized
the installation and choose "Message translations",but I could not launch
Rgui.exe successfully( Rterm.exe worked fine). If I did't choose "Message
translations", Rgui.exe worked fine.

"Message translations" is Simplified Chinese.

version

               _
platform       i386-pc-mingw32
arch           i386
os             mingw32
system         i386, mingw32
status
major          2
minor          4.0
year           2006
month          10
day            03
svn rev        39566
language       R
version.string R version 2.4.0 (2006-10-03)




------------------------------------------------------------------------

On 2006-10-5 8:06, Ei-ji Nakama wrote:

I do not understand Chinese, but recognize kanji.
RGui-zh_CN.po is written in utf-8, but charset=CP936 wrote.

  perl -p -i -e 's#charset=CP936#charset=utf-8#' RGui-zh_CN.po
  msgfmt -o RGui.mo RGui-zh_CN.po

Thanks!!  That does fix the error, at least on my system.  I'll commit 
the change to R-devel and R-patched.

Duncan Murdoch wrote:

On 2006-10-5 8:06, Ei-ji Nakama wrote:

I do not understand Chinese, but recognize kanji.
RGui-zh_CN.po is written in utf-8, but charset=CP936 wrote.

  perl -p -i -e 's#charset=CP936#charset=utf-8#' RGui-zh_CN.po
  msgfmt -o RGui.mo RGui-zh_CN.po

Thanks!!  That does fix the error, at least on my system.  I'll commit 
the change to R-devel and R-patched.

Hmm, I do understand Chinese, and I can confirm that the content
of RGui-zh_CN.po in R 2.4 is in utf-8 rather than CP936.

I can also confirm that CP950(big5) for RGui-zh_TW.po is correct, and
CP932(shift-JIS) for  RGui-ja.po is also correct. (so you'll need to 
find some korean to verify CP949 for RGui-ko.po).

However, the fix is slightly "asymmetric". Out of ru, zh_CN, zh_TW,
ja, ko, only ru in R-2.4.0/po/*.po is in localised encoding,
(the others 4 in UTF-8), whereas RGui-*.po, after the fix, all
are in localised encoding except RGui-zh_CN.po .

I would propose correcting the encoding of the *content*, rather
than the charset tag, so that Rgui-* all uses localised ones (CP932, 
CP936, CP949, CP950). That should be better for older windows...

On 10/6/2006 1:35 PM, Hin-Tak Leung wrote:

Duncan Murdoch wrote:

On 2006-10-5 8:06, Ei-ji Nakama wrote:

I do not understand Chinese, but recognize kanji.
RGui-zh_CN.po is written in utf-8, but charset=CP936 wrote.

  perl -p -i -e 's#charset=CP936#charset=utf-8#' RGui-zh_CN.po
  msgfmt -o RGui.mo RGui-zh_CN.po

Thanks!!  That does fix the error, at least on my system.  I'll commit
the change to R-devel and R-patched.

Hmm, I do understand Chinese, and I can confirm that the content
of RGui-zh_CN.po in R 2.4 is in utf-8 rather than CP936.

I can also confirm that CP950(big5) for RGui-zh_TW.po is correct, and
CP932(shift-JIS) for  RGui-ja.po is also correct. (so you'll need to
find some korean to verify CP949 for RGui-ko.po).

However, the fix is slightly "asymmetric". Out of ru, zh_CN, zh_TW,
ja, ko, only ru in R-2.4.0/po/*.po is in localised encoding,
(the others 4 in UTF-8), whereas RGui-*.po, after the fix, all
are in localised encoding except RGui-zh_CN.po .

I would propose correcting the encoding of the *content*, rather
than the charset tag, so that Rgui-* all uses localised ones (CP932,
CP936, CP949, CP950). That should be better for older windows...

I did try that, but iconv didn't want to convert the file from UTF-8 to
CP936.  I've no idea why not.

In any case, those files only need to be readable by the translation
teams, not by end-users, so I don't think the asymmetry matters:  if a
translator finds it easy to work in UTF-8 that's fine for R, as long as
it is correctly recorded.

Duncan Murdoch

On 10/6/2006 1:35 PM, Hin-Tak Leung wrote:

Duncan Murdoch wrote:

On 2006-10-5 8:06, Ei-ji Nakama wrote:

I do not understand Chinese, but recognize kanji.
RGui-zh_CN.po is written in utf-8, but charset=CP936 wrote.

  perl -p -i -e 's#charset=CP936#charset=utf-8#' RGui-zh_CN.po
  msgfmt -o RGui.mo RGui-zh_CN.po

Thanks!!  That does fix the error, at least on my system.  I'll commit
the change to R-devel and R-patched.

Hmm, I do understand Chinese, and I can confirm that the content
of RGui-zh_CN.po in R 2.4 is in utf-8 rather than CP936.

I can also confirm that CP950(big5) for RGui-zh_TW.po is correct, and
CP932(shift-JIS) for  RGui-ja.po is also correct. (so you'll need to
find some korean to verify CP949 for RGui-ko.po).

However, the fix is slightly "asymmetric". Out of ru, zh_CN, zh_TW,
ja, ko, only ru in R-2.4.0/po/*.po is in localised encoding,
(the others 4 in UTF-8), whereas RGui-*.po, after the fix, all
are in localised encoding except RGui-zh_CN.po .

I would propose correcting the encoding of the *content*, rather
than the charset tag, so that Rgui-* all uses localised ones (CP932,
CP936, CP949, CP950). That should be better for older windows...

I did try that, but iconv didn't want to convert the file from UTF-8 to
CP936.  I've no idea why not.

In any case, those files only need to be readable by the translation
teams, not by end-users, so I don't think the asymmetry matters:  if a
translator finds it easy to work in UTF-8 that's fine for R, as long as
it is correctly recorded.

On Fri, 6 Oct 2006, Duncan Murdoch wrote:

On 10/6/2006 1:35 PM, Hin-Tak Leung wrote:

I would propose correcting the encoding of the *content*, rather
than the charset tag, so that Rgui-* all uses localised ones (CP932,
CP936, CP949, CP950). That should be better for older windows...

That was the intention, but the translator marked it incorrectly, and it 
appeared to be valid CP936 so not picked up by me.

I need to sort out with the translator a valid CP936 version of that 
file: it contains a character that is not in CP936.