The X11 device driver does not provide the X window manager with an icon (_NET_WM_ICON) or, under some circumstances, with a class (WM_CLASS). This hinders usability under the new stable version of Ubuntu, which has a (new) user interface centered around icons. I am not sure if this was a conscious choice by r-core or simply a low priority. In case of the latter, I attach a patch against R-devel (as of 6 June) that specifies: 1) _NET_WM_ICON as a slightly tweaked version of Rlogo-5.png (48x48 pixels, circle filled-in with white to be legible; ARGB data hardcoded as a constant array in a new file "rlogo_icon.h"). 2) WM_CLASS (for reasons unclear to me, previously WM_CLASS was only set #ifndef USE_Xt) l As Ubuntu is the single most popular linux distribution, perhaps others will find this patch useful. I have tested on both 32- and 64-bit versions of linux. Regards, Philip -------------- next part -------------- A non-text attachment was scrubbed... Name: r_icon_class.patch Type: text/x-patch Size: 20839 bytes Desc: not available URL: <https://stat.ethz.ch/pipermail/r-devel/attachments/20120607/a174fe9f/attachment.bin>
x11 icon and class
4 messages · Philip Johnson, Dirk Eddelbuettel, Davor Cubranic
3 days later
On 7 June 2012 at 15:05, Philip Johnson wrote:
| The X11 device driver does not provide the X window manager with an icon
| (_NET_WM_ICON) or, under some circumstances, with a class (WM_CLASS).
Nice! That had bugged me for a few years too as things like various taskbars
and panels never show the R logo for eg the plot windows.
If R Core does not respond to this, I suggest you and take this offline and
try to see if I can make this a regular patch for the Debian package which
underlies the Ubuntu distribution package as well as the Debian / Ubuntu
"backports" available via CRAN. I guess I could test with the pre-releases
of R 2.15.1.
Cheers, Dirk
| This hinders usability under the new stable version of Ubuntu, which has
| a (new) user interface centered around icons.
|
| I am not sure if this was a conscious choice by r-core or simply a low
| priority. In case of the latter, I attach a patch against R-devel (as
| of 6 June) that specifies:
| 1) _NET_WM_ICON as a slightly tweaked version of Rlogo-5.png (48x48
| pixels, circle filled-in with white to be legible; ARGB data hardcoded
| as a constant array in a new file "rlogo_icon.h").
| 2) WM_CLASS (for reasons unclear to me, previously WM_CLASS was only
| set #ifndef USE_Xt)
| l
| As Ubuntu is the single most popular linux distribution, perhaps others
| will find this patch useful. I have tested on both 32- and 64-bit
| versions of linux.
|
| Regards,
| Philip
|
| ----------------------------------------------------------------------
| diff -Naur R-devel/src/modules/X11/devX11.c R-devel-patched/src/modules/X11/devX11.c
| --- R-devel/src/modules/X11/devX11.c 2012-05-28 20:53:33.000000000 -0400
| +++ R-devel-patched/src/modules/X11/devX11.c 2012-06-07 14:48:40.359041743 -0400
| @@ -70,6 +70,7 @@
| typedef int (*X11IOhandler)(Display *);
|
| #include "devX11.h"
| +#include "rlogo_icon.h" /* hard-coded ARGB icon */
|
| #include <Rmodules/RX11.h>
|
| @@ -1580,8 +1581,9 @@
|
| XStoreName(display, xd->window, xd->title);
|
| -#ifndef USE_Xt
| /* For those too idle to make use of Xt (PR#14588) */
| + /* Not sure reason for above comment -- even with Xt, WM_CLASS
| + is not set on xd->window */
| XClassHint *chint;
| chint = XAllocClassHint();
| if (chint) {
| @@ -1590,7 +1592,13 @@
| XSetClassHint(display, xd->window, chint);
| XFree(chint);
| }
| -#endif
| +
| + /* set window icon -- hardcoded into rlogo_icon.h */
| + XChangeProperty(display, xd->window,
| + XInternAtom(display, "_NET_WM_ICON", False),
| + XInternAtom(display, "CARDINAL", False), 32,
| + PropModeReplace,
| + (const unsigned char*) rlogo_icon, 2 + 48*48);
|
| /* set up protocols so that window manager sends */
| /* me an event when user "destroys" window */
| diff -Naur R-devel/src/modules/X11/rlogo_icon.h R-devel-patched/src/modules/X11/rlogo_icon.h
| --- R-devel/src/modules/X11/rlogo_icon.h 1969-12-31 19:00:00.000000000 -0500
| +++ R-devel-patched/src/modules/X11/rlogo_icon.h 2012-06-07 14:54:07.219041708 -0400
| @@ -0,0 +1,51 @@
| +unsigned long rlogo_icon[] = {
| + 48,48,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x1868983,0x27e837a,0x6959595,0x2a888b85,0x5881857f,0x7d7f827b,0x9b7e827a,0xb17c8078,0xc07c7f78,0xc97c8179,0xca797e76,0xc3777c73,0xb4777b74,0x9d747971,0x8074786f,0x5b757870,0x2e797d75,0x77e847e,0x164685f,0x16b7168,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x38a8d88,0x68b8f89,0x288b8e89,0x71868983,0xba848881,0xf6838780,0xff838780,0xff838780,0xff848881,0xff848881,0xff848881,0xff848881,0xff858982,0xff81857e,0xff80847d,0xff7f837b,0xff7c8079,0xff787e76,0xff747a71,0xff71766d,0xf86f736b,0xbf6d7269,0x766c7169,0x2c70726c,0x7656a62,0x3666b63,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x58a8e87,0x1a8d918b,0x608a8f88,0xc9888c86,0xff878c85,0xff898d87,0xff8b8f89,0xff8c9089,0xfe8d918b,0xfe8f938d,0xff90948e,0xff91958e,0xff91968f,0xff91968f,0xff939891,0xff8f948d,0xff8f938c,0xff8d918b,0xff8a8f88,0xff878c85,0xfe858983,0xfe82867f,0xff7d8179,0xff777c73,0xff70756c,0xff6a6f66,0xcf676c63,0x65666c63,0x1d656a61,0x55f655b,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x290978c,0x208e918b,0x728c9089,0xe48a8f88,0xff8c918a,0xff90948d,0xff91958e,0xfe929690,0xff91958e,0xff8d918a,0xff8d9189,0xff8e938c,0xff92968f,0xff959992,0xff959a93,0xff959a93,0xff959a93,0xff949992,0xff939891,0xff939891,0xff929790,0xff91968f,0xff90948e,0xff8e938c,0xff8a8f88,0xff858a83,0xfe81857e,0xff7b8078,0xff737870,0xff696e65,0xe963685f,0x7a61675e,0x245f645b,0x3626660,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x1091948f,0x5a8f928c,0xd68e918a,0xff90948d,0xff969a93,0xfe979a94,0xfe939790,0xff878c84,0xff7b7f77,0xff7a7f77,0xff858983,0xff92968f,0xff9b9f99,0xff9da19b,0xff999e97,0xff91958f,0xfe888c84,0xff7e827b,0xff767a73,0xff70756d,0xff6d726a,0xff6c7068,0xff6d7169,0xff6f746b,0xff72776f,0xff777c74,0xff7c8179,0xfe81867f,0xfe848881,0xfe82857f,0xfe7b8079,0xff72776f,0xff656a62,0xdd5e635a,0x605b6058,0x135b6057,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x2792968f,0x9790938d,0xff91948f,0xff9a9e97,0xfe9da19b,0xfe959992,0xff7e837b,0xff6f746c,0xff7c8078,0xff949791,0xffa8aca6,0xffb4b7b2,0xffafb2ad,0xfe999d97,0xff81857e,0xff6e726b,0xff5d6259,0xff53584f,0xfc4b4f47,0xf2464b43,0xea454941,0xe4454941,0xe1444941,0xe0474c44,0xe34b5048,0xe84f544c,0xf052574e,0xfa555a51,0xff5a6057,0xff62685e,0xff6e736b,0xff7a7e77,0xfe7d827a,0xfe797e75,0xff6d7169,0xff5d625a,0xa0575c53,0x2d54594f,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x3791958f,0xbf91958e,0xff969993,0xffa5a9a3,0xfea0a49e,0xff848881,0xff6a6f67,0xff7b8078,0xff9ea29b,0xffbabdb8,0xffc6c9c4,0xfeb5b8b3,0xfe949892,0xff737770,0xff535850,0xf93e423a,0xdc30342d,0xf150534e,0xde52544f,0xf8767874,0xdf7f817d,0xca888a86,0xbb8f918d,0xb4929591,0xb3949692,0xba929490,0xc68e918c,0xda8a8c88,0xec82847f,0xe871756e,0xeb686d65,0xeb5c6159,0xf2545950,0xff61665e,0xff72766e,0xff797e76,0xff71766e,0xff5e635b,0xc853584f,0x3f4e534b,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x37949892,0xcf92968f,0xff999d96,0xfeafb2ad,0xfe9a9e97,0xff72776f,0xff6d7169,0xff979b95,0xffbfc2be,0xffd1d3d0,0xfec0c2be,0xfe979c95,0xff6c7069,0xff434740,0xdf252922,0xe14a4d48,0xf180817d,0xc0999b96,0xe6d7d7d5,0xc3fbfbfa,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xf5ffffff,0xd5ffffff,0xdbe2e3e1,0xdebdbfbb,0xdf949892,0xe8787c76,0xe85b6057,0xfa5f645b,0xff72776f,0xfe737870,0xff60655c,0xd94f544b,0x3f4a4f47,0x0,0x0,0x0,
| + 0x0,0x0,0x21959993,0xcb949791,0xff9a9e97,0xfeb8bbb6,0xff939690,0xff666b63,0xff787d75,0xffaeb1ac,0xffd5d7d4,0xffd4d6d3,0xfeaeb1ac,0xff797d76,0xff42463f,0xf331352e,0xeb61635f,0xd0969895,0xc5cbced2,0xf4eef1f7,0xffeef1f7,0xfceaedf2,0xffe7eaef,0xfae5e7ed,0xfae5e7ed,0xfae5e7ed,0xfae5e7ed,0xfae5e7ed,0xfae5e7ed,0xfae5e7ed,0xfae5e7ed,0xfae5e7ed,0xfbe5e7ed,0xfee6e9ee,0xfde9ecf1,0xf1f4f5f9,0xd4ffffff,0xd5f7f6f4,0xe8c4c5c1,0xe790938e,0xea62675f,0xfe696f66,0xff73776f,0xff5d625a,0xd4494e46,0x29494d45,0x0,0x0,
| + 0x0,0x4989e98,0xa7939791,0xff989c96,0xfebbbeb9,0xff979a94,0xff60655c,0xff7e827b,0xffbabdb9,0xffe0e2df,0xffd3d5d2,0xfea0a49e,0xff5f645d,0xf8272b24,0xdb3a3e38,0xe3a1a3a1,0xebf0f0f0,0xffffffff,0xd9bcc5d8,0xf4a0acc7,0xfaa0acc7,0xfaa1adc8,0xfaa1adc8,0xfaa1adc8,0xfaa1adc8,0xfaa1adc8,0xfaa1adc8,0xfaa1adc8,0xfaa1adc8,0xfaa1adc8,0xfaa1adc8,0xfaa1adc8,0xfaa1adc8,0xfaa1adc9,0xf99daac5,0xec94a0b9,0xe397a1b7,0xd8b3b8c7,0xcef1f2f7,0xe5fdfdfc,0xd1c4c7c3,0xd37d827a,0xfe6c7068,0xff72776f,0xff565b53,0xb442473f,0x85c5f57,0x0,
| + 0x0,0x52959993,0xff969a93,0xffaeb2ad,0xfeabaea9,0xff5e625a,0xff7b7f78,0xffbabdb8,0xffe7e8e6,0xffd6d7d4,0xfe9ea19c,0xff525750,0xec1a1e17,0xce555753,0xd7d6d6d5,0xf7ffffff,0xffffffff,0xffffffff,0xcf929eb8,0xf79babcd,0xff7a86a2,0xff6a748d,0xff6a738c,0xff6a738c,0xff6a738c,0xff6a738c,0xff6a738c,0xff6a738c,0xff6a738c,0xff6a738c,0xff6a738c,0xff6a738c,0xff6a738c,0xff6a748d,0xff69758e,0xff6c7894,0xff7785a4,0xe96d7b9d,0xd76d7790,0xcfb6bac5,0xe5ffffff,0xebefefee,0xb2949791,0xf16d7269,0xff70756d,0xff474c44,0x6140443d,0x0,
| + 0x1b0a7b6,0xd2949891,0xff9ca09a,0xfec5c7c3,0xff656961,0xff6e736a,0xffaaada8,0xffe9eae8,0xffe0e2e0,0xfea9ada7,0xff565a52,0xeb181c16,0xbf565955,0xd7ededed,0xfdffffff,0xffffffff,0xfefefefe,0xffffffff,0xd093a0b8,0xf6a7b6d9,0xff5b657b,0xff6d7a96,0xff707c9a,0xff707c9a,0xff6f7c99,0xff6c7997,0xff6c7997,0xff6d7a98,0xff6d7a98,0xff6d7a98,0xff6d7a97,0xff6d7a98,0xff6e7a98,0xff6e7b99,0xff6d7b98,0xfe6a7692,0xfe5f6a83,0xff606b83,0xff677490,0xee58637c,0xc9a5a9b4,0xf8fdfdfe,0xdffcfcfc,0xaea9ada7,0xf7767b72,0xff646961,0xde393d36,0x65e6358,
| + 0x39959992,0xff949892,0xffadb0ab,0xff9b9e99,0xff5a5e56,0xff90938d,0xffd8d9d7,0xffefefee,0xffc1c3bf,0xff6e726b,0xf821241e,0xd5525451,0xd9eeefee,0xfcffffff,0xfffefefe,0xfefefefe,0xffffffff,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff545d73,0xff7f91b6,0xff8495bc,0xff8395bc,0xff8496bc,0xffabbada,0xffaab9dc,0xffa5b5d9,0xffa5b5d9,0xffa5b5d9,0xffa7b6da,0xffa5b4d8,0xff9babcf,0xff90a1c5,0xff8798be,0xff7e8fb5,0xff7786aa,0xfe6f7d9c,0xfe636f89,0xff5b6781,0xea454e63,0xe4d1d3d7,0xffffffff,0xe9ffffff,0xb39fa29c,0xfd7a7f77,0xff42473f,0x473a3d35,
| + 0x8292968f,0xff969a94,0xfebdc0bc,0xff62675e,0xff70756d,0xffb0b3ad,0xfff1f1f0,0xffdfe1de,0xfe9ca09a,0xff393d36,0xea3b3d39,0xdecacac9,0xfdffffff,0xffffffff,0xfefefefe,0xffffffff,0xffffffff,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff555e75,0xff8192b8,0xff8597be,0xff8496be,0xfea4b4d6,0xff8e9cb9,0xff5e6880,0xff5d6880,0xff5d6880,0xff5d6880,0xff5d677f,0xff5c677f,0xff68748e,0xfe7b89a7,0xff8291b2,0xff8495ba,0xff8799c1,0xff8496bd,0xff7887a9,0xfe677490,0xff424c62,0xd3797d88,0xf4f2f2f3,0xffffffff,0xeefcfcfc,0xce82867f,0xff5e635b,0x9430342e,
| + 0xb590948d,0xff969a93,0xffafb2ad,0xff53584f,0xff82867e,0xffcaccc8,0xfff4f5f4,0xffcbcdc9,0xff777b74,0xf320241d,0xe9787a76,0xfcffffff,0xffffffff,0xfefefefe,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8496bd,0xff95a4c4,0xfe474f64,0xf31b1e26,0xcb222632,0xcd222632,0xcd222632,0xcc212531,0xcd222633,0xe9343b4b,0xff515c74,0xfe6f7b99,0xfe7886a5,0xff8294b9,0xff8597bf,0xff8597bf,0xfe7a89a9,0xff545f78,0xd3303745,0xf4e2e3e4,0xffffffff,0xffffffff,0xd0cccdca,0xff7a7e77,0xc62d312a,
| + 0xcf8e928b,0xff949892,0xff9b9e98,0xff585d54,0xff8d928a,0xffd8d9d7,0xfff0f1f0,0xffbcbfba,0xff5b5f57,0xeb31342e,0xe0abacab,0xffffffff,0xfefefefe,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8497be,0xff8895b4,0xfc3f475b,0xc7383a40,0xfcf7f7f7,0xf9efefef,0xf9efefef,0xf9efefef,0xfdf0f0f1,0xd3e0e1e4,0xaf6d778c,0xff717e9d,0xfe7783a0,0xff7080a1,0xff8699c0,0xff8597bf,0xff8596b9,0xff616d88,0xf2282e3b,0xfbdbdbdc,0xffffffff,0xffffffff,0xc8fcfcfc,0xfa8b8f88,0xdf2f332d,
| + 0xce8a8e88,0xff91958f,0xff8b8f89,0xff5b5f57,0xff90958e,0xffdbdddb,0xffedeeed,0xffb5b8b3,0xff4f544c,0xf74b4e49,0xf3cccdcd,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8497be,0xff8795b3,0xfc40475c,0xc33d3e45,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xfeffffff,0xe3cfd4dd,0xdc8091b3,0xff7a87a2,0xff6a7896,0xff8799c1,0xff8496be,0xff8e9ec2,0xfe67748f,0xff222734,0xffd7d7d9,0xfeffffff,0xffffffff,0xfdffffff,0xde949992,0xdf31352f,
| + 0xb4878b85,0xff8d918b,0xff8a8e87,0xff5b6057,0xff8d908a,0xffd5d7d5,0xffecedec,0xffb5b8b3,0xff535851,0xf74e524d,0xf2d0d1cf,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8497be,0xff8795b3,0xfc40475c,0xc33d3e45,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xfefefefe,0xffffffff,0xe6d6dae4,0xd88f9fc4,0xff7e8aa4,0xff657290,0xff8799c1,0xff8396bd,0xff95a6c9,0xff646f89,0xf01a1e28,0xfbd8d8d9,0xffffffff,0xfefefefe,0xffffffff,0xdc969a94,0xc5292d27,
| + 0x83858982,0xff878c85,0xfe8a8e87,0xff5d625a,0xff82857f,0xffc4c6c3,0xffecedeb,0xffbdbfba,0xff6a6e67,0xe93e423c,0xdeb7b8b6,0xffffffff,0xfefefefe,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8497be,0xff8795b3,0xfc40475c,0xc43d3f45,0xffffffff,0xfefefefe,0xfefefefe,0xfefefefe,0xfffefefe,0xf5fcfcfd,0xecc0c9dc,0xfd9daed1,0xff818ba1,0xff5f6c8a,0xff889ac2,0xff8899c0,0xfe9dacd0,0xff535c72,0xcb0f1119,0xf2dfdfdf,0xffffffff,0xffffffff,0xc7ffffff,0xf78a8e88,0x9321241f,
| + 0x37848881,0xff80847d,0xff888c85,0xff6b7068,0xff737870,0xffaaada8,0xffe6e7e5,0xffcbceca,0xff898d86,0xef343931,0xe58e8f8c,0xffffffff,0xffffffff,0xfefefefe,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8597be,0xff808ead,0xfd495268,0xe54f5668,0xfebcc4d5,0xf9bac0d2,0xfab9c0d2,0xfbbac1d2,0xeeb5bdcf,0xd894a3c1,0xf899abcf,0xff99a5ba,0xfe636e81,0xff7686ab,0xff8597bf,0xfea5b6d8,0xff8c9ab8,0xff292e3c,0xc0525356,0xf0f0f0f0,0xffffffff,0xffffffff,0xcadedfdd,0xf8626660,0x47272926,
| + 0x0,0xd27c8078,0xff81857e,0xfe7c817a,0xff696e66,0xff8e928b,0xffcbcdca,0xffd9dad8,0xfea7aba5,0xff5a5f56,0xe65b5f58,0xdbdfdfde,0xffffffff,0xfffefefe,0xfefefefe,0xffffffff,0xffffffff,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8597be,0xfe7786a5,0xff6c7893,0xff7d8cab,0xff808eb1,0xff8190b2,0xff8090b2,0xff8090b1,0xff8493b5,0xff9eaecd,0xffa0adc1,0xfe5d6573,0xff657390,0xff90a2c8,0xfeaabad8,0xffa5b4d0,0xff4a5265,0xe90c0d12,0xd4c5c4c5,0xf7ffffff,0xffffffff,0xf8ffffff,0xbd9a9e98,0xd8333732,0x3676868,
| + 0x0,0x51797d76,0xff787d75,0xff81857e,0xfe73776f,0xff787d75,0xffa3a5a0,0xffd4d6d3,0xffc1c4c0,0xff8e928b,0xf3464b42,0xcd7d807b,0xe0fcfdfc,0xffffffff,0xfffefefe,0xfefefefe,0xffffffff,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8597be,0xff8294ba,0xff58647d,0xff596276,0xff5d657a,0xff5e677b,0xff5e677b,0xff5f677c,0xff5e667a,0xff4e5667,0xff525a6c,0xfe8f9db8,0xfeacbcdc,0xffacbad6,0xff8390aa,0xfe3a4153,0xfa16181c,0xad7e7e7f,0xe9fbfbfb,0xffffffff,0xffffffff,0xa1c4c6c2,0xf5646762,0x6121221f,0x0,
| + 0x0,0x0,0xae747870,0xff787c74,0xff7d817a,0xfe747871,0xff848880,0xffacafaa,0xffc9ccc7,0xfeb1b5af,0xff7f847d,0xe4484d45,0xd29c9f9b,0xeefcfcfc,0xfcffffff,0xffffffff,0xfefefefe,0xffffffff,0xd093a0b9,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8496bd,0xff8597be,0xff92a3c9,0xff8b9bc0,0xff8797bb,0xff8697bb,0xff8394b8,0xff8090b5,0xff7c8eb3,0xff91a2c6,0xfea8b6d4,0xff707c95,0xff4b5469,0xfa353b4d,0xf01e212b,0xe3252527,0xcaa2a2a2,0xf5ffffff,0xffffffff,0xf2ffffff,0xeae4e6e4,0xf8828680,0xba282b27,0x3515154,0x0,
| + 0x0,0x0,0x1a73796f,0xd36f736b,0xff757a72,0xfe7b7e77,0xfe797d75,0xff898d86,0xffabaea9,0xffbbbeba,0xfea8aca6,0xff7e827b,0xec575c54,0xc6939791,0xdff0f0ef,0xfdffffff,0xffffffff,0xffffffff,0xcf93a0b9,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8496bd,0xfe92a3c8,0xffabbad6,0xff97a5c3,0xff94a1bf,0xff93a1bf,0xff8f9dbd,0xfe8c9cbe,0xff8698bc,0xff8e9fc3,0xff68748d,0xfe242937,0xfa2b2e37,0xd23c3e43,0xb9868786,0xccf3f3f3,0xf8ffffff,0xffffffff,0xf0f9faf9,0xc6d6d7d4,0xee7e817b,0xd8333731,0x23272a27,0x0,0x0,
| + 0x0,0x0,0x0,0x326d7069,0xd66a6f67,0xff70756d,0xff787d75,0xfe7d817a,0xff8a8e87,0xffa3a6a1,0xffafb2ac,0xfea2a69f,0xff848881,0xef5c6158,0xd9858882,0xe5d2d3d1,0xedfafaf9,0xffffffff,0xd095a1ba,0xf6a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8496bd,0xffa3b3d3,0xfe66728b,0xfb2f3544,0xeb31384a,0xee333b4d,0xfc495369,0xff697693,0xfe7c8ba9,0xff7988a8,0xff626e88,0xfe616c86,0xef8490ab,0xcda5aec3,0xdbd5d8e1,0xf3fbfbfd,0xeaffffff,0xedededec,0xcbb7bab5,0xfd757972,0xde3a3d39,0x3d1f211e,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x36696e66,0xc5656a62,0xff6a6f67,0xff737870,0xfe7c8079,0xff888b84,0xff999c96,0xffa2a6a0,0xfe9ca09a,0xff8b8f88,0xff6d7169,0xe76c7068,0xda9fa39d,0xe9dadad6,0xd18a97af,0xf7a5b5d8,0xff555e75,0xff8092b8,0xff8597be,0xff8496be,0xff8b9ab9,0xfd3b4255,0xdd212227,0xdd929397,0xdc8a8b90,0xdd747984,0xf95d6880,0xff6e7c9a,0xfe707d9a,0xfe697591,0xff6c7892,0xff6c7894,0xff687493,0xeb5d6985,0xd4969ba6,0xd4c2c4c1,0xda8c9089,0xff61655e,0xcd333731,0x401d1f1b,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x26636960,0xa160665d,0xf6646960,0xff6a6f67,0xff767a72,0xfe81857d,0xff8e928b,0xff999c96,0xfe989c95,0xfe90948d,0xff81857d,0xfe6c7068,0xe8777a70,0xea727e92,0xfca5b5d7,0xff555e75,0xff8092b8,0xff8597be,0xff8497be,0xff8694b3,0xfc40475c,0xbe404249,0xffffffff,0xffffffff,0xdfffffff,0xd9a7adba,0xf462708e,0xff7b88a6,0xff687592,0xff687593,0xfe636e89,0xfe6b7791,0xff606c87,0xf94a5367,0xff5c6161,0xfb51544e,0xa9262924,0x2c171a15,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0xd63685f,0x695d6258,0xc95d6259,0xff60655d,0xff686d65,0xff737870,0xfe80837c,0xff8b8f88,0xff91958e,0xfe91968f,0xff8d918b,0xff84877d,0xff747f90,0xffa5b4d6,0xfe555e75,0xff8092b8,0xff8597be,0xff8497be,0xff8795b3,0xfd40475c,0xd0383a3f,0xd6dddedb,0xe8d8d9d7,0xb9cdceca,0xb5b0b3b3,0xe869748a,0xff717f9e,0xff7784a1,0xff7e8fb3,0xff8496bd,0xff7281a2,0xfe66738e,0xff515c74,0xff3d434f,0x7f252928,0xe121206,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x2d5b5f56,0x79585d54,0xcf585e55,0xff5a5f57,0xff61665e,0xff6b7068,0xff767b73,0xfe80847c,0xff878b84,0xff8c9087,0xff798497,0xffa5b4d6,0xff555e75,0xff8092b8,0xff8597be,0xff8497be,0xff8795b3,0xfe40485c,0xf33c3f41,0xdf92968f,0xed959993,0xcd848881,0xe08d918a,0xf983898f,0xff6d7a98,0xff7784a1,0xff717f9e,0xff8698c0,0xff8799c1,0xff7584a4,0xff626e89,0xff495267,0x68505869,0x3dae3fe,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x366685c,0x2d535850,0x65535850,0xae535850,0xf352584f,0xff555a51,0xff5b6058,0xff636860,0xff6c7066,0xff6e7a8c,0xfea5b4d6,0xff555e75,0xff8092b8,0xff8597be,0xff8497be,0xfe8795b3,0xff40485c,0xff3e4143,0xff898d85,0xff81857d,0xff7c8079,0xff72766e,0xff616662,0xff576071,0xff7380a0,0xfe7884a2,0xff7888ab,0xff8799c1,0xff8293b9,0xfe6d7a98,0xff56617a,0xe5495264,0x2f565b6a,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x1b4f544c,0x374c5149,0x664e524a,0xa04d5249,0xd54c5249,0xff4b4e44,0xff5f6a7c,0xffa4b3d5,0xfe555e75,0xff8092b8,0xff8597be,0xff8497be,0xfe8795b3,0xff40475b,0xff2a2d2e,0xff51554c,0xff484c44,0xff41453e,0xff3c4039,0xd5363b33,0xc1444c53,0xf26e7b99,0xff74819e,0xff7482a1,0xff8496bd,0xff8698c0,0xff7a8aac,0xff677490,0xff4b556b,0x9d4e5566,0xe555b67,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x35b5f58,0x14494e46,0x22464b43,0x2534351d,0xb86d7b97,0xfba6b5d7,0xff555e75,0xff8092b8,0xff8597be,0xff8497be,0xff8795b3,0xfe40475b,0xde23262a,0x833d4038,0x6d3a3d37,0x4d393d36,0x3032352e,0x2026291f,0x29585f68,0xa2697591,0xff717f9e,0xfe7684a1,0xff7686a8,0xff8699c0,0xff8597be,0xfe6f7d9b,0xff5f6b85,0xff474f63,0x4b575d6c,0x2c9cccc,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0xa17585a5,0xfaa7b6d9,0xff535c72,0xff7e90b6,0xff8295bc,0xff8294bc,0xff8593b2,0xfd40485c,0xb6292b32,0x28c8941,0x6434641,0x0,0x0,0x0,0x0,0x4d67728c,0xee6e7b97,0xff727f9c,0xfe7582a1,0xff8192b8,0xff8396be,0xff7e8fb3,0xfe687490,0xff4f5a72,0xd14a5264,0x14525869,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0xa17585a4,0xfaa7b6d9,0xff717d97,0xffa5b5d7,0xffabbadd,0xffabbadd,0xff9faecd,0xfd40475c,0xb22a2c33,0x0,0x0,0x0,0x0,0x0,0x0,0xe9099aa,0x9766728e,0xff727f9e,0xfe8492b0,0xff9aa8ca,0xffadbcdf,0xffacbbde,0xfe9eadcc,0xff7f8ca8,0xff4a5369,0x76545b69,0x6616670,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0xa37a8bac,0xfc72809c,0xff515b72,0xff515a71,0xff515b72,0xff515b72,0xff505a71,0xfe3a4255,0xb32a2c33,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x486c7690,0xe267738f,0xff56627b,0xff4c566b,0xff4e586e,0xff4e586e,0xff4e576d,0xff4d576c,0xff465065,0xf9434c5d,0x27616977,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x7e697289,0xcc393d48,0xd330333b,0xd330333b,0xd330333b,0xd330333b,0xd330333b,0xd931353e,0x983d4047,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x8ddebff,0x77525868,0xd4393d47,0xca2f323a,0xca30333b,0xca30333b,0xca30333b,0xca30333b,0xca30333b,0xd0343741,0x7a5a606c,0x6686e7b,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| + 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
| +};
|
| ----------------------------------------------------------------------
| ______________________________________________
| R-devel at r-project.org mailing list
| https://stat.ethz.ch/mailman/listinfo/r-devel
Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com
1 day later
On 2012-06-07, at 12:05 PM, Philip Johnson wrote:
The X11 device driver does not provide the X window manager with an icon (_NET_WM_ICON) or, under some circumstances, with a class (WM_CLASS). This hinders usability under the new stable version of Ubuntu, which has a (new) user interface centered around icons. [...] 2) WM_CLASS (for reasons unclear to me, previously WM_CLASS was only set #ifndef USE_Xt)
A few comments in the bug database give a hint why this is conditional (http://bugs.r-project.org/bugzilla3/show_bug.cgi?id=14588): (1) "resources are only handled in the Xt case" (comment #1) (2) "Still no explanation as to why Xt is not used, and this should be conditional on that case." (comment #3) Now that GUI libraries typically don't rely on Xt any more (e.g., Gtk), but WM_CLASS (and possibly other resources) are still used by window managers, it arguably makes sense for the X11 driver to always set this property. Davor
1 day later
On 06/12/2012 03:50 PM, Davor Cubranic wrote:
On 2012-06-07, at 12:05 PM, Philip Johnson wrote:
The X11 device driver does not provide the X window manager with an icon (_NET_WM_ICON) or, under some circumstances, with a class (WM_CLASS). This hinders usability under the new stable version of Ubuntu, which has a (new) user interface centered around icons. [...] 2) WM_CLASS (for reasons unclear to me, previously WM_CLASS was only set #ifndef USE_Xt)
A few comments in the bug database give a hint why this is conditional (http://bugs.r-project.org/bugzilla3/show_bug.cgi?id=14588): (1) "resources are only handled in the Xt case" (comment #1) (2) "Still no explanation as to why Xt is not used, and this should be conditional on that case." (comment #3)
True, however, as far as I could tell, these comments do not apply to the current code for the following reasons: (1) ./configure --with-x requires that Xt be present (2) devX11.c includes a line "#define USE_Xt 1" -- implying that Xt is *always* used if compiling for X11 (3) Xt* functions are only used in a single small block in the code, and no windows are created in that code -- and thus no X resources are EVER set. I *think* that the only purpose of this code is to test whether the window manager allows the user to specify window position and size. But these fields in XSizeHints are noted in the current man pages as "obsolete and left solely for compatibility reasons". (4) deleting all Xt code makes no discernable difference in the device driver behaviour on my (admittedly modern) linux distribution.
Now that GUI libraries typically don't rely on Xt any more (e.g., Gtk), but WM_CLASS (and possibly other resources) are still used by window managers, it arguably makes sense for the X11 driver to always set this property.
This is my argument in a nutshell. I understand there is a general reluctance to delete old code because it might still be used on an old system somewhere, but I think my proposed change would only be adding functionality, not removing it. After I sent the patch, I discovered that the integration with the new Ubuntu interface works even better if WM_CLASS matches the name of the executable -- i.e. if the class were "R" rather than "R_x11". I don't want to spam this list, but I am happy to send a revised patch if asked. Regards, Philip