Skip to content

strsignif.c, util.c (PR#10635)

2 messages · A.R.Runnalls at kent.ac.uk, Duncan Murdoch

#
In R 2.6.1, a couple of places (discovered using valgrind) where the
requested size of string buffers fails to account correctly for the
trailing null byte:

1. In src/appl/strsignif.c, 'f0' and 'form' at l. 108-9 each need at
least 1 extra byte.

2. In src/main/util.c, 'out' at l. 1081 needs at least one extra byte.

(Remember that the return value of strlen does not include the null byte.)

Andrew Runnalls
#
A.R.Runnalls at kent.ac.uk wrote:
At least this one is still there; I'll fix it (and take a look at the 
other, too).

Thanks!

Duncan Murdoch