Skip to content

[PATCH] Fix status in main

3 messages · Steve Grubb, Martin Morgan, Martin Maechler

#
Hello,

This is a patch to fix what appears to be a simple typo. The warning says
"invalid status assuming 0", but then instead sets runLast to 0.

Signed-of-by: Steve Grubb <sgrubb at redhat.com>

Index: src/main/main.c
===================================================================
--- src/main/main.c	(revision 72935)
+++ src/main/main.c	(working copy)
@@ -1341,7 +1341,7 @@
     status = asInteger(CADR(args));
     if (status == NA_INTEGER) {
 	warning(_("invalid 'status', 0 assumed"));
-	runLast = 0;
+	status = 0;
     }
     runLast = asLogical(CADDR(args));
     if (runLast == NA_LOGICAL) {
#
On 07/20/2017 05:31 PM, Steve Grubb wrote:
fixed in 72938 / 39.

This seemed not to have consequence, since exit() reports NA & 0377 
(i.e., 0) and the incorrect assignment to runLast is immediately 
over-written by the correct value.

Martin Morgan
This email message may contain legally privileged and/or...{{dropped:2}}
#
Yes, thank you!

Martin