Optimize code to read text-file with digits

Hi

see in line
-----Original Message-----
From: R-help [mailto:r-help-bounces at r-project.org] On Behalf Of Martin
Moller Skarbiniks Pedersen
Sent: Friday, September 8, 2017 10:49 AM
To: r-help at r-project.org
Subject: [R] Optimize code to read text-file with digits

Hi,

  Every day I try to write some small R programs to improve my R-skills.
  Yesterday I wrote a small program to read the digits from "A Million Random
Digits" from RAND.
  My code works but it is very slow and I guess the code is not optimal.

The digits.txt file downloaded from
https://www.rand.org/pubs/monograph_reports/MR1418.html
contains 20000 lines which looks like this:
00000   10097 32533  76520 13586  34673 54876  80959 09117  39292 74945
00001   37542 04805  64894 74296  24805 24037  20636 10402  00822 91665
00002   08422 68953  19645 09303  23209 02560  15953 34764  35080 33606
00003   99019 02529  09376 70715  38311 31165  88676 74397  04436 27659
00004   12807 99970  80157 36147  64032 36653  98951 16877  12171 76833

My program which is slow looks like this:

filename <- "digits.txt"
lines <- readLines(filename)
why you do not read a file as a whole e.g. by

lines<-read.table("digits.txt")

After that you do not need for cycle (but maybe I misunderstand what you really want)

remove first column

lines <- lines[,-1]

And now I am lost.
Do you want each row convert into a numeric vector? It probably exceed the precision of biggest number allowed.

Do you want to split each column to 5 numeric columns?
you can use something like

outer(lines[,1], 10^c(4:0), function(a, b) a %/% b %% 10)

to split the first column.

Or do you want one big numeric vector from all your numbers?

here you need to read values as character variables

lines<-read.table("digits.txt", colClasses="character")
numbers<-as.numeric(unlist(strsplit(as.character(lines[1,]),"")))
changes first row to numeric vector.

Anyway, can you explain what is your final goal?

Cheers
Petr
numbers <- vector('numeric')
for (i in 1:length(lines)) {

    # remove first column
    lines[i] <- sub("[^ ]+ +","",lines[i])

    # remove spaces
    lines[i] <- gsub(" ","",lines[i])

    # split the characters and convert them into numbers
    numbers <- c(numbers,as.numeric(unlist(strsplit(lines[i],""))))
}

Thanks for any advice how this program can be improved.

Regards
Martin M. S. Pedersen

      [[alternative HTML version deleted]]

______________________________________________
R-help at r-project.org mailing list -- To UNSUBSCRIBE and more, see
https://stat.ethz.ch/mailman/listinfo/r-help
PLEASE do read the posting guide http://www.R-project.org/posting-guide.html
and provide commented, minimal, self-contained, reproducible code.
________________________________
Tento e-mail a jak?koliv k n?mu p?ipojen? dokumenty jsou d?v?rn? a jsou ur?eny pouze jeho adres?t?m.
Jestli?e jste obdr?el(a) tento e-mail omylem, informujte laskav? neprodlen? jeho odes?latele. Obsah tohoto emailu i s p??lohami a jeho kopie vyma?te ze sv?ho syst?mu.
Nejste-li zam??len?m adres?tem tohoto emailu, nejste opr?vn?ni tento email jakkoliv u??vat, roz?i?ovat, kop?rovat ?i zve?ej?ovat.
Odes?latel e-mailu neodpov?d? za eventu?ln? ?kodu zp?sobenou modifikacemi ?i zpo?d?n?m p?enosu e-mailu.

V p??pad?, ?e je tento e-mail sou??st? obchodn?ho jedn?n?:
- vyhrazuje si odes?latel pr?vo ukon?it kdykoliv jedn?n? o uzav?en? smlouvy, a to z jak?hokoliv d?vodu i bez uveden? d?vodu.
- a obsahuje-li nab?dku, je adres?t opr?vn?n nab?dku bezodkladn? p?ijmout; Odes?latel tohoto e-mailu (nab?dky) vylu?uje p?ijet? nab?dky ze strany p??jemce s dodatkem ?i odchylkou.
- trv? odes?latel na tom, ?e p??slu?n? smlouva je uzav?ena teprve v?slovn?m dosa?en?m shody na v?ech jej?ch n?le?itostech.
- odes?latel tohoto emailu informuje, ?e nen? opr?vn?n uzav?rat za spole?nost ??dn? smlouvy s v?jimkou p??pad?, kdy k tomu byl p?semn? zmocn?n nebo p?semn? pov??en a takov? pov??en? nebo pln? moc byly adres?tovi tohoto emailu p??padn? osob?, kterou adres?t zastupuje, p?edlo?eny nebo jejich existence je adres?tovi ?i osob? j?m zastoupen? zn?m?.

This e-mail and any documents attached to it may be confidential and are intended only for its intended recipients.
If you received this e-mail by mistake, please immediately inform its sender. Delete the contents of this e-mail with all attachments and its copies from your system.
If you are not the intended recipient of this e-mail, you are not authorized to use, disseminate, copy or disclose this e-mail in any manner.
The sender of this e-mail shall not be liable for any possible damage caused by modifications of the e-mail or by delay with transfer of the email.

In case that this e-mail forms part of business dealings:
- the sender reserves the right to end negotiations about entering into a contract in any time, for any reason, and without stating any reasoning.
- if the e-mail contains an offer, the recipient is entitled to immediately accept such offer; The sender of this e-mail (offer) excludes any acceptance of the offer on the part of the recipient containing any amendment or variation.
- the sender insists on that the respective contract is concluded only upon an express mutual agreement on all its aspects.
- the sender of this e-mail informs that he/she is not authorized to enter into any contracts on behalf of the company except for cases in which he/she is expressly authorized to do so in writing, and such authorization or power of attorney is submitted to the recipient or the person represented by the recipient, or the existence of such authorization is known to the recipient of the person represented by the recipient.

Optimize code to read text-file with digits

Thread (10 messages)