Skip to content

Compressing code help in a loop

3 messages · Francesca PANCOTTO, Wush Wu, PIKAL Petr

Original
Francesca PANCOTTO
# 
Dear Contributors

I have a problem with a loop.

I needed to create a variable that takes values 1,2.. to 19 corresponding
to the value of a variable in a data.frame whose name is p_int$p_made and

which takes values from 406  to 211.

The problem is that this values come ordered in the wrong way when I try to
compress the loop as the system reads


107,111,207,211,311,406,407,408,409,410,411,


while they correspond to quarters-years so they should be ordered as


406-107-207-307-407?

the only solution I found was really silly. It is the following.




p_m<-matrix(0,dim(p_int)[1],1)

for (i in 1:length(p_int$p_made)){

  if (p_int$p_made[i]==406) p_m[i]<-1 else

    if (p_int$p_made[i]==107) p_m[i]<-2 else

      if (p_int$p_made[i]==207) p_m[i]<-3 else

        if (p_int$p_made[i]==307) p_m[i]<-4 else

          if (p_int$p_made[i]==407) p_m[i]<-5 else

            if (p_int$p_made[i]==108) p_m[i]<-6 else

              if (p_int$p_made[i]==208) p_m[i]<-7 else

                if (p_int$p_made[i]==308) p_m[i]<-8 else

                  if (p_int$p_made[i]==408) p_m[i]<-9 else

                    if (p_int$p_made[i]==109) p_m[i]<-10 else

                      if (p_int$p_made[i]==209) p_m[i]<-11 else

                        if (p_int$p_made[i]==309) p_m[i]<-12 else

                          if (p_int$p_made[i]==409) p_m[i]<-13 else

                            if (p_int$p_made[i]==110) p_m[i]<-14 else

                              if (p_int$p_made[i]==210) p_m[i]<-15 else

                                if (p_int$p_made[i]==310) p_m[i]<-16 else

                                  if (p_int$p_made[i]==410) p_m[i]<-17 else

                                    if (p_int$p_made[i]==111) p_m[i]<-18
else

                                      if (p_int$p_made[i]==211) p_m[i]<-19

}

Can anyone help to find something more efficient?


Thanks in advance.


Francesca
Wush Wu
# 
Dear Francesca,

Is this what you want?

```r
index <- c(406, 107, 207, 307, 407, 108, 208, 308, 408, 109, 209, 309, 409,
110, 210, 310, 410, 111, 211)
p_m <- match( p_int$p_made, index)
dim(p_m) <- c(dim(p_int)[1],1)
```

Best,
Wush
PhD Student Graduate Institute of Electrical Engineering, National Taiwan
University



2014-11-10 20:14 GMT+08:00 Francesca <francesca.pancotto at gmail.com>:

  
  


  


      

    

    
1 day later

    

      
      

        


  

        

      PIKAL Petr
    

    

      
      #
    

  


  

      
Hi

slightly more general if first number is quarter and last two are year

            

      
      
      
    

        
+ 110, 210, 310, 410, 111, 211)

year<-substr(as.character(index), 2,3)
qrt<-substr(as.character(index), 1,1)
as.numeric(factor(paste(year, qrt, sep="-")))
 [1]  1  2  3  4  5  6  7  8  9 10 11 12 13 14 15 16 17 18 19

qyTOindex <- function(x) {

year <- substr(as.character(x), 2,3)
qrt <- substr(as.character(x), 1,1)
result <-as.numeric(factor(paste(year, qrt, sep="-")))
}

qyTOindex(p_int$p_made)

Regards

Petr

            

      
      
      
    

        

      
      
    

            

      
      
      
    

        

      
      
    

        
________________________________
Tento e-mail a jak?koliv k n?mu p?ipojen? dokumenty jsou d?v?rn? a jsou ur?eny pouze jeho adres?t?m.
Jestli?e jste obdr?el(a) tento e-mail omylem, informujte laskav? neprodlen? jeho odes?latele. Obsah tohoto emailu i s p??lohami a jeho kopie vyma?te ze sv?ho syst?mu.
Nejste-li zam??len?m adres?tem tohoto emailu, nejste opr?vn?ni tento email jakkoliv u??vat, roz?i?ovat, kop?rovat ?i zve?ej?ovat.
Odes?latel e-mailu neodpov?d? za eventu?ln? ?kodu zp?sobenou modifikacemi ?i zpo?d?n?m p?enosu e-mailu.

V p??pad?, ?e je tento e-mail sou??st? obchodn?ho jedn?n?:
- vyhrazuje si odes?latel pr?vo ukon?it kdykoliv jedn?n? o uzav?en? smlouvy, a to z jak?hokoliv d?vodu i bez uveden? d?vodu.
- a obsahuje-li nab?dku, je adres?t opr?vn?n nab?dku bezodkladn? p?ijmout; Odes?latel tohoto e-mailu (nab?dky) vylu?uje p?ijet? nab?dky ze strany p??jemce s dodatkem ?i odchylkou.
- trv? odes?latel na tom, ?e p??slu?n? smlouva je uzav?ena teprve v?slovn?m dosa?en?m shody na v?ech jej?ch n?le?itostech.
- odes?latel tohoto emailu informuje, ?e nen? opr?vn?n uzav?rat za spole?nost ??dn? smlouvy s v?jimkou p??pad?, kdy k tomu byl p?semn? zmocn?n nebo p?semn? pov??en a takov? pov??en? nebo pln? moc byly adres?tovi tohoto emailu p??padn? osob?, kterou adres?t zastupuje, p?edlo?eny nebo jejich existence je adres?tovi ?i osob? j?m zastoupen? zn?m?.

This e-mail and any documents attached to it may be confidential and are intended only for its intended recipients.
If you received this e-mail by mistake, please immediately inform its sender. Delete the contents of this e-mail with all attachments and its copies from your system.
If you are not the intended recipient of this e-mail, you are not authorized to use, disseminate, copy or disclose this e-mail in any manner.
The sender of this e-mail shall not be liable for any possible damage caused by modifications of the e-mail or by delay with transfer of the email.

In case that this e-mail forms part of business dealings:
- the sender reserves the right to end negotiations about entering into a contract in any time, for any reason, and without stating any reasoning.
- if the e-mail contains an offer, the recipient is entitled to immediately accept such offer; The sender of this e-mail (offer) excludes any acceptance of the offer on the part of the recipient containing any amendment or variation.
- the sender insists on that the respective contract is concluded only upon an express mutual agreement on all its aspects.
- the sender of this e-mail informs that he/she is not authorized to enter into any contracts on behalf of the company except for cases in which he/she is expressly authorized to do so in writing, and such authorization or power of attorney is submitted to the recipient or the person represented by the recipient, or the existence of such authorization is known to the recipient of the person represented by the recipient.