[R-pkg-devel] NOTEs in packages using Rust
I think your answer suggests the nub of solution: to delete the offending vendor directory at the right time. Will try. @JosiahParry, I just remembered that I also have an extendr version that suffers from a similar affliction. Thanks. -Naras Balasubramanian Narasimhan
From: R-package-devel <r-package-devel-bounces at r-project.org> on behalf of Josiah Parry <josiah.parry at gmail.com>
Sent: Thursday, June 20, 2024 9:32:04 AM
To: Jeff Newmiller <jdnewmil at dcn.davis.ca.us>
Cc: r-package-devel at r-project.org <r-package-devel at r-project.org>
Subject: Re: [R-pkg-devel] NOTEs in packages using Rust
Sent: Thursday, June 20, 2024 9:32:04 AM
To: Jeff Newmiller <jdnewmil at dcn.davis.ca.us>
Cc: r-package-devel at r-project.org <r-package-devel at r-project.org>
Subject: Re: [R-pkg-devel] NOTEs in packages using Rust
To be clear, you need to delete the untarred folders after the build process. You only need the dependencies at build time. After the build time it has been compiled into a .so/.dll and then you must delete the vendored sources. There's no reason that installing an R package should keep the *source code *of the rust dependencies. On Thu, Jun 20, 2024 at 12:28?PM Jeff Newmiller via R-package-devel < r-package-devel at r-project.org> wrote: > I am not connected to CRAN (by a long shot), but if I were I would not > accept any of the arguments you are making here. > > I don't know what you are talking about with respect to excluding files in > tarring... you should be using the package build processes as documented in > Writing R Extensions. > > Adding a final carriage return is straightforward to do using a Makefile > as part of your vendoring updates... or you could submit patches upstream. > > On June 20, 2024 8:57:09 AM PDT, Balasubramanian Narasimhan < > naras at stanford.edu> wrote: > >I am preparing an update of Clarabel to synchronize with the upstream > >repo. When checking the package, I get NOTEs such as: > > > > Found the following CITATION file in a non-standard place: > > src/rust/vendor/clarabel/CITATION.bib > > Most likely ?inst/CITATION? should be used instead. > > > > Found the following sources/headers not terminated with a newline: > > > src/rust/vendor/lapack-sys/lapack/LAPACKE/src/lapacke_cgetsqrhrt_work.c > > > >etc. > > > >These are coming from the vendored sources and I plan to note that in my > >submission. Will that suffice? > > > >I will, of course, let the crate authors know and even submit a PR, but > >not sure if it will yield an update in a reasonable time. > > > >PS. Excluding files in tarring or fixing newlines are not an option as > >the checksums will fail. > > > >Thanks. > > > >-Naras > > > > > > [[alternative HTML version deleted]] > > > >______________________________________________ > >R-package-devel at r-project.org mailing list > >https://stat.ethz.ch/mailman/listinfo/r-package-devel > > -- > Sent from my phone. Please excuse my brevity. > > ______________________________________________ > R-package-devel at r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-package-devel > [[alternative HTML version deleted]] ______________________________________________ R-package-devel at r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel