[R-pkg-devel] Problems importing packages with SystemRequirements
Yeah, this is a bug in whoami I think. It has a tryCatch() but it does not suppress the error message from system(). Gabor
On Tue, Apr 28, 2020 at 2:35 PM <fvafrcu at mailbox.org> wrote:
Dear Uwe,
thanks for your reply.
But wouldn't checking for the SystemRequirements be the dependencies' jobs?
Looking at `whoami`'s code (which is basically a single very well structured
and clearly written file of 350 lines including roxygen comments by Gabor Csardi),
I see exactly a single call to system("whoami"), which of course gets caught if it throws an exception and it should be called on windows only. Under solaris I would expect whoami::whoami() to call `id`.
I don't understand why I'm getting this error with r-patched-solaris-x86.
Gabor, can you help?!
Best, Dominik Cullmann
On Tue, Apr 28, 2020 14:08:03, Uwe Ligges wrote:
On 28.04.2020 09:28, fvafrcu at mailbox.org wrote:
Dear Jeff, thanks for your reply, I exactly know, where gitr and whoami are called, since I constitently use the `::` operator to import from any dependency. I am pretty sure that I use those packages for intended purposes only. Furthermore, CRAN reports issues for system calls (made by `git2r` and `whoami`, I guess) for my package on r-patched-solaris-x86 only, so I am not sure how to reproduce them.
Yes, but as SystemRequirements are not alsways fullfilled, you should test whether these are available before use. Best, Uwe Ligges
Best, Dominik Cullmann On Mon, Apr 27, 2020 23:34:40, Jeff Newmiller wrote:
Maybe your use of those packages represent use cases that are not tested by those packages. If you pare down your code that triggers these problems to small reproducible examples then you can contribute them to those packages? On April 27, 2020 11:05:49 PM PDT, fvafrcu at mailbox.org wrote:
Dear All, I maintain a package that has issues `sh: whoami: not found` and `sh: git: not found` (see https://cran.r-project.org/web/checks/check_results_packager.html), albeit not having any (declared or undeclared) external dependencies -- no calls to system() or system2(). It does import functions from CRAN packages `whoami` and `git2r`, though. Mysteriously to me, neither https://cran.r-project.org/web/checks/check_results_git2r.html nor https://cran.r-project.org/web/checks/check_results_whoami.html show any issues. Has anybody any clue why this is so? Thanks anyway, Dominik Cullmann
______________________________________________ R-package-devel at r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel