Skip to content

[R-pkg-devel] Possibly mis-spelled words in DESCRIPTION

7 messages · carlos cinelli, Dirk Eddelbuettel, Duncan Murdoch +2 more

Original
carlos cinelli
# 
Hi, all!

I am about to do a maintenance update on the benford.analysis package
and when checking the package in Win Builder I get this note:


** checking CRAN incoming feasibility ... NOTE
Maintainer: 'Carlos Cinelli <carloscinelli at hotmail.com
<carloscinelli at hotmail.com>>'

Possibly mis-spelled words in DESCRIPTION:
  Analytics (3:58)
  Benford (3:8)
  Benford's (7:72)*

However, I do not think Analytics is misspelled and Benford is a
proper name (Frank Benford).

How should I proceed in this case?

Thanks!

Best,

Carlos
Uwe Ligges
#
On 08.05.2016 16:13, carlos cinelli wrote:
Submit to CRAN.

Best,
Uwe Ligges
Dirk Eddelbuettel
#
On 8 May 2016 at 16:18, Uwe Ligges wrote:
| On 08.05.2016 16:13, carlos cinelli wrote:
| > How should I proceed in this case?
| 
| Submit to CRAN.

The deeper question is if 'we all' can have a conversation about extending
the directory layout / format to add things to the packaging infrastructure.
What comes to mind is e.g.

  - a spell-checker white list (per Carlos' initial email)
  
  - more generally, 'white list' of warnings R CMD check can be quiet about [1]

  - more hooks, ie I would like to call roxygen2::roxygenize() as well as
    Rcpp::compileAttributes() when building

  - [ This place intentionally left blank. Let me hear other proposals. ]

We have a year to mess things up for R 3.4.0, so anybody else intereted in
working on this?

Dirk

[1] There is no point in telling me that Rcpp creates a shared library of
over 1 mb. It has been doing so for years.  C++ libraries have a footprint.
Duncan Murdoch
#
On 08/05/2016 10:47 AM, Dirk Eddelbuettel wrote:
This gets tricky.  You don't want to be told that your shared lib is 
over 1 MB, but I'd imagine you'd like to know if it grew over 1000 MB. 
So really you'd like to tune that note rather than suppress it, just 
like Carlos would like a white list for the spell checker rather than 
suppressing the spell check entirely.

And CRAN has accepted Rcpp even though it generates that note, so it 
probably wouldn't object if you set the limit high enough to suppress 
the note currently, but it would object if you tried to suppress the 
note entirely (because they don't want 1000 MB shared libs either, and 
don't want to have to check your package manually).

So this would require work on CRAN's side to recognize when your 
requested suppressions are acceptable.  And I'm sure there would be 
arguments back and forth, which also suck up CRAN's time and energy.

The technical implementation is much easier than the procedural one.

Duncan Murdoch
carlos cinelli
# 
Thanks, Uwe, I will submit then.
Best,
Carlos

On Sun, May 8, 2016 at 11:18 AM, Uwe Ligges <ligges at statistik.tu-dortmund.de

  
  


  


      

    

    

      
      

        


  

        

      Hadley Wickham
    

    

      
      #
    

  


  

      
On Sun, May 8, 2016 at 10:15 AM, Duncan Murdoch

        
<murdoch.duncan at gmail.com> wrote:

            

      
      
      
    

        
Agreed, but currently CRAN has an informal whitelist in their brains
which they have to remember when you resubmit a package.  It is
possible that we could come up with a system that makes life easier
for CRAN because they could see the whitelist in a standard format and
easily diff with the last submission.

This would also make life easier for people like me and Dirk who have
to run R CMD check on 1000's of downstream dependencies. We have no
idea whether or not we're seeing check issues that are expected or
need to be acted upon.

Hadley

  
    

      
      
    

  


  


      

    

    

      
      

        


  

        

      Uwe Ligges
    

    

      
      #
    

  


  

      
On 08.05.2016 17:44, Hadley Wickham wrote:

            

      
      
      
    

        
Indeed, such details could be improved.

For spell checking (the original question) I do not care too much, 
because you frequently get false positives and CRAN decides by looking 
on the list. And we do not want to force users to maintain an extra 
list. But perhaps we can discuss whether we add a feature to R that a 
list could be provided within the package.

For Notes about the size: Of course, the package itself cannot say that 
it is OK to include huge components, otherwise all maintainers would 
simply declare that it is OK. So that would need to be maintained on 
CRAN. Not sure it makes sense to do that for the few exceptions we allow.

And as you see, then we need to think about exceptions for all sorts of 
Notes and how to include that both technically as well as procedural 
into the CRAN process.

Anyway, not all CRAN team members are listining here, so perhaps start 
to discuss this with R-core (where the current CRAN team is a subset of).

Best,
Uwe