[R-pkg-devel] AlgDesign C Issue

  Hi!

I'm currently the maintainer of AlgDesign, though my C skill is clearly a
little too low for the task.

It has become necessary for me to fix some issues with the code that had
defined true, false, and bool in the header file (wheeler.h).

Lines 23 and 24 currently have:

#define true 1
#define false 0

There used to be a line 25 that had:

#define bool int

I removed line 25 and changed all occurrences in the C code of "bool" to
"int".   But this doesn't seem to have fully resolved the issue.

The current checks on AlgDesign generate a warning based on header lines 23
and 24:

Debian: <

https://win-builder.r-project.org/incoming_pretest/AlgDesign_1.2.1.2_20250331_023833/Debian/00check.log

Status: 1 WARNING, 1 NOTE

I'm not sure what this means yet, nor how to resolve it properly.  I would
love some help in working forward, if possible.

Thank you very much!
--
Jerome

        [[alternative HTML version deleted]]

Hi Michael!

I'd like to make the smallest change possible to Bob Wheeler's original
code so I'm not sure if using <stdbool.h> is the best route forward.

I do see that the definitions are the same there.  Is there a low-cost way
to use that header file or just those definitions?

 Since the compiler will supply stdbool.h, it's safer to use that than to

Hi Duncan!

 >? Since the compiler will supply stdbool.h, it's safer to use that 

than to try to emulate it.

Understood.?It seems like the definitions are exactly the same between 
the two.

Currently there is no use of "bool" in any of the code (after having 
changed bool to int everywhere in the code).

So I think I can replace the two lines in the original code with a call 
to include the <stdbool.h> header --- does that seem reasonable?? ?Can I 
use an include statement there in place of those two lines?

Thank you!
-- 
Jerome

On Mon, Mar 31, 2025 at 11:28?AM Duncan Murdoch 
<murdoch.duncan at gmail.com <mailto:murdoch.duncan at gmail.com>> wrote:

    On 2025-03-31 9:28 a.m., Jerome Braun wrote:

     > Hi Michael!
     >
     > I'd like to make the smallest change possible to Bob Wheeler's

    original

     > code so I'm not sure if using <stdbool.h> is the best route forward.
     >
     > I do see that the definitions are the same there.? Is there a

    low-cost way

     > to use that header file or just those definitions?

    The problem is that the definitions may vary from compiler to compiler,
    and the error message you're getting only shows up some of them.? Since
    the compiler will supply stdbool.h, it's safer to use that than to try
    to emulate it.

    Duncan Murdoch