On 4 October 2007 at 08:30, Johannes Ranke wrote:
| Hi Dirk,
|
| * Dirk Eddelbuettel <edd at debian.org> [071003 23:50]:
| >
| > Hi Johannes,
| >
| > On 3 October 2007 at 22:23, Johannes Ranke wrote:
| > | Hi Dirk, hi list,
| > |
| > | I just ran into a slight problem while building the recommended packages
| > | for CRAN in a chroot environment against the fresh backport of your R
| > | 2.6.0 packages. It seems that R CMD javareconf wants to change files in
| >
| > You are ahead of me, as this hook is to be used by rJava and CRAN packages
| > using rJava. I actually haven't used it yet, as I didn't get around to
| > putting it in, and the testing it. So far only step 1 has been done :)
|
| I wonder if it is necessary to run this command (if /usr/bin/java
| exists) for every R package that is being built, regardless if it needs
| java or not. I have no idea how many people are out there building debs
| for R packages, and you'd probably argue that they better use pbuilder.
Well, but are other users really calling r-cran.mk ?
To the best of my knowledge, it is used only in the (numerous) r-cran-*
packages --- which are all built in a pbuilder chroots that do _not_ contain
/usr/bin/java by default so the test comes up false and no R CMD javareconf
is run --- and the (not really official) pkg-bioc effort of automatic
creation of Debian package, which also uses pbuilder behaves the same.
So I saw no downside.
What have I overlooked? If and when users install packages directly from
CRAN via R's install.packages(), this command isn't run either.
But I may have overlooked something obvious, so let me know. We can always
back it out for a -2 revision.