Message-ID: <CAPPM_gS1ZOn++5ymPx3Z9ndKFg3OEoePnMo9EUVreCdQMQnenA@mail.gmail.com>
Date: 2017-05-24T20:33:12Z
From: Joshua Ulrich
Subject: Error in addTxn - Quantstrat
In-Reply-To: <CAPLrYES35G7B3KqLm0gGLYC3757uqAhPd4qyq6zwATX8k6gPDw@mail.gmail.com>
On Wed, May 24, 2017 at 2:37 PM, Daniel Cegie?ka
<daniel.cegielka at gmail.com> wrote:
>
> ok, I found a bug.
>
> https://github.com/braverock/blotter/blob/master/R/addTxn.R#L81
>
> as.Date("2017-01-01") return time-based object:
>
> if(!is.timeBased(TxnDate) ){
> TxnDate<-as.POSIXct(TxnDate)
> }
>
> and TxnDate != POSIXct
>
Yes, I arrived at the same conclusion before I sent my initial email.
I mentioned it in the bug report I created:
https://github.com/braverock/blotter/issues/51
Apologies for not mentioning it in the email... there was no need for
you to spend time on it.
> Best,
> Daniel
>
> _______________________________________________
> R-SIG-Finance at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-sig-finance
> -- Subscriber-posting only. If you want to post, subscribe first.
> -- Also note that this is not the r-help list where general R questions should go.
--
Joshua Ulrich | about.me/joshuaulrich
FOSS Trading | www.fosstrading.com
R/Finance 2017 | www.rinfinance.com