quantmod bug ?

I recently posted a problem concerning shaded regions with quantmod
package. More precisely, I used the function addTA with a boolean vector:

On 08/08/2012 10:05 AM, Olivier MARTIN wrote:

I recently posted a problem concerning shaded regions with quantmod
package. More precisely, I used the function addTA with a boolean vector:

As has been posted to this list many times in the past year, development of
graphics in quantmod has moved wholly to chart_Series and add_TA, and the
older chartSeries and addTA are unlikely to get much (any) attention.  The
old code is just too difficult to maintain.

If you can replicate your problem with the newer functions, you're much more
likely to get a response from someone with commit access to the code.

Regards,

  - Brian

--
Brian G. Peterson
http://braverock.com/brian/
Ph: 773-459-4973
IM: bgpbraverock

chartSeries is on CRAN and ?chart_Series says it's "highly experimental."

IMHO it's really not fair to tell people that they should use
undocumented code.

Garrett

Hi all,

I recently posted a problem concerning shaded regions with quantmod package.
More precisely,
I used the function addTA with a boolean vector: for example
addTA(vecB,col="green",border=NA,on=-1)
where vecB is the boolean vector.

In some cases, the shading result was not conform
with the boolean vector. I checked the R source  program, and more
precisely the function chartTA() in TA.R file. So in the function
chartTA, it seems that there is a mistake with the vector x.pos.
the vector is given by
 x.pos <- 1 + spacing * (1:length(x.range))
and it seems that this vector should be
x.pos <- 1:(spacing*x.range[2])

So I hope this indication would be  relevant for people who work on
the improvements of this package.

Best regards.
O.