a bug in R Mac GUI

Hi Simon and Randy,

Randy, what do you mean with 'I have a history'? How did you create your example? I can't reproduce the problem (but I'm on R-devel and compile everything locally, including R.app). 

That would indeed be pretty serious as most of my source files contain comments as in your example.

Simon, I'm not 100% sure either (h?, it was 10 years ago!), but I think we decided to stay as close as possible to the behavior of the Carbon version of R.app, although I believe I opted for removing comment-only lines. Of course, that's just a decision. And different from Randy's example just now.

Rob J. Goedman
goedman at icloud.com



On Nov 5, 2013, at 9:34 AM, Randy Lai <randy.cs.lai at gmail.com> wrote:

I would rather think that it is a bug. It happens when "clean up history entries" is on but ?strip comment? is off.

If I have a history of two lines:
# this is a comment
a = 100

the current version of GUI would returns
this is a comment
a = 100


On Nov 5, 2013, at 5:49 AM, Simon Urbanek <simon.urbanek at r-project.org> wrote:

I'm CCig Rob since he designed the history code so he may comment on whether it's by design or not. I dimly remember that this was intended, but I'm not 100% sure.

Thanks,
Simon


Begin forwarded message:

From: Randy Lai <randy.cs.lai at gmail.com>
Subject: [R-SIG-Mac] a bug in R Mac GUI
Date: November 2, 2013 at 12:55:51 AM EDT
To: r-sig-mac at r-project.org

Hi guys,

I have fixed a bug in R Mac GUI that the comment symbol # is trimmed when cleanup history entries is checked.
This only works for R 3.0.x for Mac.

A complied version can be found in the following link.

the fix: https://github.com/randy3k/R-Mac-GUI/commit/d8d387236b208d49b3cda9a3d82ca72e70b40110
the binary: https://github.com/randy3k/R-Mac-GUI/releases