Skip to content

[Rcpp-devel] Extending <Rcpp/module/Module_generated_class_constructor.h>

5 messages · Tama Ma, Romain Francois, Dirk Eddelbuettel

#
Dear Rcpp developers,

	I want to export a class with a constructor with 7 argments. However, in <Rcpp/module/Module_generated_class_constructor.h>, we have only support up to 6 arguments, eg.

    template <
        typename U0, 
        typename U1, 
        typename U2, 
        typename U3, 
        typename U4, 
        typename U5
    >   
    self& constructor( const char* docstring = 0, ValidConstructor valid = &yes_arity<6> ){
        AddConstructor( new Constructor_6<Class,U0,U1,U2,U3,U4,U5> , valid, docstring ) ; 
        return *this ;   
    }   


	Can this be extended? And in what way I can help with it?

	Thank you very much.

Best regards,
Tama Ma


ETH Zurich
Tama Ma
Instit?t f?r Theoretische Physik
HIT K 31.3
Wolfgang-Pauli-Strasse 27
ETH H?nggerberg
8093 Z?rich
Switzerland

pingnang at itp.phys.ethz.ch
www.phys.ethz.ch/~pingnang

+41 44 633 76 55  (Office Phone)
+41 44 633 11 15  (Office Fax)
#
Sure. The pattern is quite easy to extend.

You need to update this file and also Module_generated_Constructor.h

send us a patch against the current svn tree.

$ svn checkout svn://svn.r-forge.r-project.org/svnroot/rcpp
$ # make the changes
$ svn diff > patch.txt

And then you send the patch.txt file.

We look forward for the patch.

Romain

Le 03/12/10 20:55, Tama Ma a ?crit :

  
    
#
Dear Romain,

	Here it is. Hope it works fine.

Best regards,
Tama Ma

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch-r2695.txt
URL: <http://lists.r-forge.r-project.org/pipermail/rcpp-devel/attachments/20101203/07d96696/attachment.txt>
-------------- next part --------------
On Dec 3, 2010, at 9:02 PM, Romain Francois wrote:

            
#
Thanks, 

I'm out right now, i will have a look later if nobody beats me to it. 

Romain



Le 3 d?c. 2010 ? 09:46 PM, Tama Ma <pingnang at phys.ethz.ch> a ?crit :
#
Hi Tama.
On 3 December 2010 at 21:46, Tama Ma wrote:
| 	Here it is. Hope it works fine.

Applied cleanly -- but unit tests don't currently pass (which can of course
be due to ongoing work on our side -- such is the nature of changing code in
repositories). I am sure we will pan it out over the weekend.  

If you feel like it, look for the unit tests and add one for the seventh
argument as icing on the cake.

Thanks for the contribution and the quick turnaround!

Cheers, Dirk