[Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

Le 29/03/13 16:37, Dirk Eddelbuettel a ?crit :
On 29 March 2013 at 16:20, romain at r-enthusiasts.com wrote:
| Cool. I'll have a look when I'm back from easter weekend.

Sounds good.

And that point, it would be really nice if you could also restore the ability
to build Rcpp, which appears to have broken with your Data.Frame patch.

Details are below.
Should be back up now. With new versions of DataFrame::create that work 
better.
Dirk

edd at max:~/svn/rcpp/pkg$ R CMD build Rcpp
* checking for file ?Rcpp/DESCRIPTION? ... OK
* preparing ?Rcpp?:
* checking DESCRIPTION meta-information ... OK
* cleaning src
* running ?cleanup?
* installing the package to process help pages
       -----------------------------------
* installing *source* package ?Rcpp? ...
** libs
ccache g++-4.7 -I/usr/share/R/include -DNDEBUG -I../inst/include/     -fpic  -g0 -O3 -Wall -pipe -Wno-variadic-macros -pedantic -c Date.cpp -o Date.o
ccache g++-4.7 -I/usr/share/R/include -DNDEBUG -I../inst/include/     -fpic  -g0 -O3 -Wall -pipe -Wno-variadic-macros -pedantic -c Module.cpp -o Module.o
In file included from ../inst/include/RcppCommon.h:102:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/Named.h: In instantiation of ?Rcpp::traits::named_object<SEXPREC*> Rcpp::Argument::operator=(const T&) [with T = int]?:
Module.cpp:40:128:   required from here
../inst/include/Rcpp/Named.h:34:52: error: ?wrap? was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
In file included from ../inst/include/RcppCommon.h:117:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/internal/wrap.h:902:13: note: ?template<class InputIterator> SEXPREC* Rcpp::wrap(InputIterator, InputIterator)? declared here, later in the translation unit
In file included from ../inst/include/RcppCommon.h:102:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/Named.h: In instantiation of ?Rcpp::traits::named_object<SEXPREC*> Rcpp::Argument::operator=(const T&) [with T = char [5]]?:
Module.cpp:40:146:   required from here
../inst/include/Rcpp/Named.h:34:52: error: ?wrap? was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
In file included from ../inst/include/RcppCommon.h:117:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/internal/wrap.h:902:13: note: ?template<class InputIterator> SEXPREC* Rcpp::wrap(InputIterator, InputIterator)? declared here, later in the translation unit
In file included from ../inst/include/RcppCommon.h:102:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/Named.h: In instantiation of ?Rcpp::traits::named_object<SEXPREC*> Rcpp::Argument::operator=(const T&) [with T = char [12]]?:
Module.cpp:52:127:   required from here
../inst/include/Rcpp/Named.h:34:52: error: ?wrap? was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
In file included from ../inst/include/RcppCommon.h:117:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/internal/wrap.h:902:13: note: ?template<class InputIterator> SEXPREC* Rcpp::wrap(InputIterator, InputIterator)? declared here, later in the translation unit
In file included from ../inst/include/RcppCommon.h:102:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/Named.h: In instantiation of ?Rcpp::traits::named_object<SEXPREC*> Rcpp::Argument::operator=(const T&) [with T = char [15]]?:
Module.cpp:61:133:   required from here
../inst/include/Rcpp/Named.h:34:52: error: ?wrap? was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
In file included from ../inst/include/RcppCommon.h:117:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/internal/wrap.h:902:13: note: ?template<class InputIterator> SEXPREC* Rcpp::wrap(InputIterator, InputIterator)? declared here, later in the translation unit
In file included from ../inst/include/RcppCommon.h:102:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/Named.h: In instantiation of ?Rcpp::traits::named_object<SEXPREC*> Rcpp::Argument::operator=(const T&) [with T = char [22]]?:
Module.cpp:67:133:   required from here
../inst/include/Rcpp/Named.h:34:52: error: ?wrap? was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
In file included from ../inst/include/RcppCommon.h:117:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/internal/wrap.h:902:13: note: ?template<class InputIterator> SEXPREC* Rcpp::wrap(InputIterator, InputIterator)? declared here, later in the translation unit
In file included from ../inst/include/RcppCommon.h:102:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/Named.h: In instantiation of ?Rcpp::traits::named_object<SEXPREC*> Rcpp::Argument::operator=(const T&) [with T = char [11]]?:
Module.cpp:73:142:   required from here
../inst/include/Rcpp/Named.h:34:52: error: ?wrap? was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
In file included from ../inst/include/RcppCommon.h:117:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/internal/wrap.h:902:13: note: ?template<class InputIterator> SEXPREC* Rcpp::wrap(InputIterator, InputIterator)? declared here, later in the translation unit
In file included from ../inst/include/RcppCommon.h:102:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/Named.h: In instantiation of ?Rcpp::traits::named_object<SEXPREC*> Rcpp::Argument::operator=(const T&) [with T = char [20]]?:
Module.cpp:77:139:   required from here
../inst/include/Rcpp/Named.h:34:52: error: ?wrap? was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
In file included from ../inst/include/RcppCommon.h:117:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/internal/wrap.h:902:13: note: ?template<class InputIterator> SEXPREC* Rcpp::wrap(InputIterator, InputIterator)? declared here, later in the translation unit
In file included from ../inst/include/RcppCommon.h:102:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/Named.h: In instantiation of ?Rcpp::traits::named_object<SEXPREC*> Rcpp::Argument::operator=(const T&) [with T = SEXPREC*]?:
Module.cpp:265:50:   required from here
../inst/include/Rcpp/Named.h:34:52: error: ?wrap? was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
In file included from ../inst/include/RcppCommon.h:117:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/internal/wrap.h:902:13: note: ?template<class InputIterator> SEXPREC* Rcpp::wrap(InputIterator, InputIterator)? declared here, later in the translation unit
In file included from ../inst/include/RcppCommon.h:102:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/Named.h: In instantiation of ?Rcpp::traits::named_object<SEXPREC*> Rcpp::Argument::operator=(const T&) [with T = bool]?:
Module.cpp:266:39:   required from here
../inst/include/Rcpp/Named.h:34:52: error: ?wrap? was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
In file included from ../inst/include/RcppCommon.h:117:0,
                  from ../inst/include/Rcpp.h:27,
                  from Module.cpp:22:
../inst/include/Rcpp/internal/wrap.h:902:13: note: ?template<class InputIterator> SEXPREC* Rcpp::wrap(InputIterator, InputIterator)? declared here, later in the translation unit
make: *** [Module.o] Error 1
ERROR: compilation failed for package ?Rcpp?
* removing ?/tmp/RtmpfejSO9/Rinst312b332a9a19/Rcpp?
       -----------------------------------
ERROR: package installation failed
edd at max:~/svn/rcpp/pkg$
|
| Romain
|
| Le 2013-03-29 16:00, Dirk Eddelbuettel a ?crit :
| > On 29 March 2013 at 09:40, Dirk Eddelbuettel wrote:
| > |
| > | On 29 March 2013 at 15:24, romain at r-enthusiasts.com wrote:
| > | | Le 2013-03-29 14:31, Dirk Eddelbuettel a ?crit :
| > | | > On 29 March 2013 at 09:11, romain at r-enthusiasts.com wrote:
| > | | > |
| > | | > | Hello,
| > | | > |
| > | | > | This is related to this change:
| > | | > |
| > | | > | 2013-01-15  Dirk Eddelbuettel  <edd at debian.org>
| > | | > |
| > | | > | 	* src/api.cpp (Rcpp): Commented-out coerce_to_string() for
| > real
| > | | > and
| > | | > | 	complex arguments as R-devel (as of today) dislikes use of
| > non-API
| > | | > | 	functions Rf_EncodeComplex?, ?Rf_EncodeReal?,
| > ?Rf_formatComplex?
| > | | > |
| > | | > | So maybe Dirk has a plan to fix it.
| > | | >
| > | | > I do not.
| > | |
| > | | Fine. So I'll fix it.
| > |
| > | Hold on.
| > |
| > | I am in the middle of it. I do have a poor replacementment for
| > EncodeReal,
| > | and am about to test one for complex. Will post soon.
| > |
| > | Am not covering scientific notation at this point.
| >
| > Ok, here replacement candidates.  Kudos to Kevin for sending
| > something
| > reproducible that triggered this.  This snipped below grew from his
| > code and
| > provids replacement candidates for coerce_to_string() for the real
| > and
| > complex cases, not using the internal R functions (which I also did
| > not look
| > at).  Obviously the function headers need to change from the sample
| > to what
| > api.cpp uses.
| >
| > What we get is simple snprintf() calls which almost surely is less
| > featureful
| > than what R has, but please complaon to R Core about the sillyness of
| > us not
| > being able to use _existing and tested functions_.  It's painful.
| >
| >
| > Dirk
| >
| > #include <Rcpp.h>
| >
| > static const char* dropTrailing0(char *s, char cdec) {
| >     /* Note that  's'  is modified */
| >     char *p = s;
| >     for (p = s; *p; p++) {
| >       if(*p == cdec) {
| >         char *replace = p++;
| > 	      while ('0' <= *p  &&  *p <= '9')
| > 		      if(*(p++) != '0')
| > 		        replace = p;
| > 	        if(replace != p)
| > 		        while((*(replace++) = *(p++)))
| > 		           ;
| > 	        break;
| > 	   }
| >     }
| >     return s;
| > }
| >
| > //template <>
| > // const char* coerce_to_string/*<REALSXP>*/(double x){
| > // [[Rcpp::export]]
| > const char* coerce_to_stringRE(double x){
| >     int w,d,e ;
| >     // cf src/main/format.c in R's sources:
| >     //   The return values are
| >     //     w : the required field width
| >     //     d : use %w.df in fixed format, %#w.de in scientific format
| >     //     e : use scientific format if != 0, value is number of exp
| > digits - 1
| >     //
| >     //   nsmall specifies the minimum number of decimal digits in
| > fixed format:
| >     //   it is 0 except when called from do_format.
| >     Rf_formatReal( &x, 1, &w, &d, &e, 0 ) ;
| >     // we are no longer allowed to use this:
| >     //     char* tmp = const_cast<char*>( Rf_EncodeReal(x, w, d, e,
| > '.') );
| >     // so approximate it poorly as
| >     char tmp[128];
| >     snprintf(tmp, 127, "%*.*f", w, d, x);
| >     //Rcpp::Rcout << "Vec is " << vec << std::endl;
| >     return dropTrailing0(tmp, '.');
| >
| > }
| >
| > //template <>
| > //const char* coerce_to_string/*<CPLXSXP>*/(Rcomplex x){
| > // [[Rcpp::export]]
| > std::string coerce_to_stringCP(Rcomplex x){
| >     int wr, dr, er, wi, di, ei;
| >     // cf src/main/format.c in R's sources:
| >     Rf_formatComplex(&x, 1, &wr, &dr, &er, &wi, &di, &ei, 0);
| >     //return Rf_EncodeComplex(x, wr, dr, er, wi, di, ei, '.' );
| >
| >     // we are no longer allowed to use this:
| >     //     Rf_EncodeComplex(x, wr, dr, er, wi, di, ei, '.' );
| >     // so approximate it poorly as
| >     char tmp[128];
| >     snprintf(tmp, 127, "%*.*f+%*.*fi", wr, dr, x.r, wi, di, x.i);
| >     return std::string(tmp);  // force a copy
| > }
| >
| > using namespace Rcpp;
| >
| > // // [[Rcpp::export]]
| > // IntegerVector counts(NumericVector x) {
| > //  return table(x);
| > // }
|

Romain Francois
Professional R Enthusiast
+33(0) 6 28 91 30 30

R Graph Gallery: http://gallery.r-enthusiasts.com

Nice. 

And it builds, but doesn't pass (all) tests yet:

checking tests ...
  Running ?doRUnit.R? [185s/193s]
 ERROR
Running the tests in ?tests/doRUnit.R? failed.
Last 13 lines of output:
  Executing test function test.wstring_param  ...  done successfully.

  Executing test function test.wstring_return  ...  done successfully.

  saving txt unit test report to '/home/edd/svn/rcpp/pkg/Rcpp.Rcheck/tests/Rcpp-unitTests.txt'
  saving html unit test report to '/home/edd/svn/rcpp/pkg/Rcpp.Rcheck/tests/Rcpp-unitTests.html'
  Error in eval(expr, envir, enclos) : 
    unit test problems: 1 failures, 0 errors
  Error in checkEquals(createTwoStringsAsFactors(), DF, msg = "DataFrame create2 stringsAsFactors = false") :   Length mismatch: comparison on first 2 componentsComponent 2: 'current' is not a factorDataFrame create2 stringsAsFactors = false
  Calls: source -> withVisible -> eval -> eval
  Execution halted

Does it for you?
Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com
Le 02/04/13 17:01, Dirk Eddelbuettel a ?crit :
On 2 April 2013 at 16:36, Romain Francois wrote:
| Le 29/03/13 16:37, Dirk Eddelbuettel a ?crit :
| >
| > On 29 March 2013 at 16:20, romain at r-enthusiasts.com wrote:
| > | Cool. I'll have a look when I'm back from easter weekend.
| >
| > Sounds good.
| >
| > And that point, it would be really nice if you could also restore the ability
| > to build Rcpp, which appears to have broken with your Data.Frame patch.
| >
| > Details are below.
|
| Should be back up now. With new versions of DataFrame::create that work
| better.

Nice.

And it builds, but doesn't pass (all) tests yet:

checking tests ...
   Running ?doRUnit.R? [185s/193s]
  ERROR
Running the tests in ?tests/doRUnit.R? failed.
Last 13 lines of output:
   Executing test function test.wstring_param  ...  done successfully.

   Executing test function test.wstring_return  ...  done successfully.

   saving txt unit test report to '/home/edd/svn/rcpp/pkg/Rcpp.Rcheck/tests/Rcpp-unitTests.txt'
   saving html unit test report to '/home/edd/svn/rcpp/pkg/Rcpp.Rcheck/tests/Rcpp-unitTests.html'
   Error in eval(expr, envir, enclos) :
     unit test problems: 1 failures, 0 errors
   Error in checkEquals(createTwoStringsAsFactors(), DF, msg = "DataFrame create2 stringsAsFactors = false") :   Length mismatch: comparison on first 2 componentsComponent 2: 'current' is not a factorDataFrame create2 stringsAsFactors = false
   Calls: source -> withVisible -> eval -> eval
   Execution halted

Does it for you?
Aah. No it does not.

This is not supported by the new code:

DataFrame::create(
		_["a"] = v,
		_["b"] = s,
		_["stringsAsFactors"] = false );

I forgot that we support this and ran the tests just before making that 
change.

Do we really need this feature ?
Romain Francois
Professional R Enthusiast
+33(0) 6 28 91 30 30

R Graph Gallery: http://gallery.r-enthusiasts.com

blog:            http://blog.r-enthusiasts.com
|- http://bit.ly/ZTFLDo : Simpler R help tooltips
`- http://bit.ly/YFsziW : R Help tooltips
| Do we really need this feature ?

I like to maintain existing APIs and interfaces.  

I haven't had time to look at how you now impletement the DataFrame ctor via
List -- but is there no way to catch that stringsAsFactor yes/no choice and
accomidate it?

This choice strikes me as a pretty central feature at the R side of things.

Dirk
Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com
Le 02/04/13 17:33, Dirk Eddelbuettel a ?crit :
On 2 April 2013 at 17:16, Romain Francois wrote:
| Do we really need this feature ?

I like to maintain existing APIs and interfaces.

I haven't had time to look at how you now impletement the DataFrame ctor via
List -- but is there no way to catch that stringsAsFactor yes/no choice and
accomidate it?

This choice strikes me as a pretty central feature at the R side of things.

Dirk
Sure. I'm working on it now.
Romain Francois
Professional R Enthusiast
+33(0) 6 28 91 30 30

R Graph Gallery: http://gallery.r-enthusiasts.com

blog:            http://blog.r-enthusiasts.com
|- http://bit.ly/ZTFLDo : Simpler R help tooltips
`- http://bit.ly/YFsziW : R Help tooltips
| Le 02/04/13 17:33, Dirk Eddelbuettel a ?crit :
| >
| > | Do we really need this feature ?
| >
| > I like to maintain existing APIs and interfaces.
| >
| > I haven't had time to look at how you now impletement the DataFrame ctor via
| > List -- but is there no way to catch that stringsAsFactor yes/no choice and
| > accomidate it?
| >
| > This choice strikes me as a pretty central feature at the R side of things.
| >
| > Dirk
| 
| Sure. I'm working on it now.

Super, thanks!

Dirk
Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com
Maybe not. I think a function in library should do only one thing, and for
DataFrame::create it is building a data.frame. If the users wish to convert
string to factor, one should do it explicitly, may with a help function
such as `stringsToFactor` or `as.factor`. stringsAsFactor is an important
feature at R side, but does RCpp have to match the exact interface of R?

For now, RCpp doesn't really support factor. Returning a data.frame with
factor element would make it useless for RCpp.

Hi Romain,

I'm curious about the difference between the code on SVN and the old one. I
read the code, and understand the new one is using List, while the old one
actually call something like as.data.frame(data.frame(t1, t2, ...)) on R
side. I just don't know why one would work while the other doesn't.

On Tue, Apr 2, 2013 at 10:16 AM, Romain Francois

Le 02/04/13 17:01, Dirk Eddelbuettel a ?crit :

On 2 April 2013 at 16:36, Romain Francois wrote:
| Le 29/03/13 16:37, Dirk Eddelbuettel a ?crit :
| >
| > On 29 March 2013 at 16:20, romain at r-enthusiasts.com wrote:
| > | Cool. I'll have a look when I'm back from easter weekend.
| >
| > Sounds good.
| >
| > And that point, it would be really nice if you could also restore the
ability
| > to build Rcpp, which appears to have broken with your Data.Frame
patch.
| >
| > Details are below.
|
| Should be back up now. With new versions of DataFrame::create that work
| better.

Nice.

And it builds, but doesn't pass (all) tests yet:

checking tests ...
   Running ?doRUnit.R? [185s/193s]
  ERROR
Running the tests in ?tests/doRUnit.R? failed.
Last 13 lines of output:
   Executing test function test.wstring_param  ...  done successfully.

   Executing test function test.wstring_return  ...  done successfully.

   saving txt unit test report to '/home/edd/svn/rcpp/pkg/Rcpp.**
Rcheck/tests/Rcpp-unitTests.**txt'
   saving html unit test report to '/home/edd/svn/rcpp/pkg/Rcpp.**
Rcheck/tests/Rcpp-unitTests.**html'
   Error in eval(expr, envir, enclos) :
     unit test problems: 1 failures, 0 errors
   Error in checkEquals(**createTwoStringsAsFactors(), DF, msg =
"DataFrame create2 stringsAsFactors = false") :   Length mismatch:
comparison on first 2 componentsComponent 2: 'current' is not a
factorDataFrame create2 stringsAsFactors = false
   Calls: source -> withVisible -> eval -> eval
   Execution halted

Does it for you?

Aah. No it does not.

This is not supported by the new code:

DataFrame::create(
                _["a"] = v,
                _["b"] = s,
                _["stringsAsFactors"] = false );

I forgot that we support this and ran the tests just before making that
change.

Do we really need this feature ?

--
Romain Francois
Professional R Enthusiast
+33(0) 6 28 91 30 30

R Graph Gallery: http://gallery.r-enthusiasts.**com<http://gallery.r-enthusiasts.com>

blog:            http://blog.r-enthusiasts.com
|- http://bit.ly/ZTFLDo : Simpler R help tooltips
`- http://bit.ly/YFsziW : R Help tooltips

______________________________**_________________
Rcpp-devel mailing list
Rcpp-devel at lists.r-forge.r-**project.org<Rcpp-devel at lists.r-forge.r-project.org>
https://lists.r-forge.r-**project.org/cgi-bin/mailman/**
listinfo/rcpp-devel<https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/rcpp-devel>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.r-forge.r-project.org/pipermail/rcpp-devel/attachments/20130402/6a67f814/attachment-0001.html>
Le 02/04/13 20:04, Chenliang Xu a ?crit :
Maybe not. I think a function in library should do only one thing, and
for DataFrame::create it is building a data.frame. If the users wish to
convert string to factor, one should do it explicitly, may with a help
function such as `stringsToFactor` or `as.factor`. stringsAsFactor is an
important feature at R side, but does RCpp have to match the exact
interface of R?

For now, RCpp doesn't really support factor. Returning a data.frame with
factor element would make it useless for RCpp.

Hi Romain,

I'm curious about the difference between the code on SVN and the old
one. I read the code, and understand the new one is using List, while
the old one actually call something like as.data.frame(data.frame(t1,
t2, ...)) on R side. I just don't know why one would work while the
other doesn't.
We were calling

data.frame(t1, t2, ... )

Now we do:

as.data.frame( list(t1, t2, ...) )

(what actually happens is more complex as it deals with names)
On Tue, Apr 2, 2013 at 10:16 AM, Romain Francois
<romain at r-enthusiasts.com <mailto:romain at r-enthusiasts.com>> wrote:

    Le 02/04/13 17:01, Dirk Eddelbuettel a ?crit :

        On 2 April 2013 at 16:36, Romain Francois wrote:
        | Le 29/03/13 16:37, Dirk Eddelbuettel a ?crit :
        | >
        | > On 29 March 2013 at 16:20, romain at r-enthusiasts.com
        <mailto:romain at r-enthusiasts.com> wrote:
        | > | Cool. I'll have a look when I'm back from easter weekend.
        | >
        | > Sounds good.
        | >
        | > And that point, it would be really nice if you could also
        restore the ability
        | > to build Rcpp, which appears to have broken with your
        Data.Frame patch.
        | >
        | > Details are below.
        |
        | Should be back up now. With new versions of DataFrame::create
        that work
        | better.

        Nice.

        And it builds, but doesn't pass (all) tests yet:

        checking tests ...
            Running ?doRUnit.R? [185s/193s]
           ERROR
        Running the tests in ?tests/doRUnit.R? failed.
        Last 13 lines of output:
            Executing test function test.wstring_param  ...  done
        successfully.

            Executing test function test.wstring_return  ...  done
        successfully.

            saving txt unit test report to
        '/home/edd/svn/rcpp/pkg/Rcpp.__Rcheck/tests/Rcpp-unitTests.__txt'
            saving html unit test report to
        '/home/edd/svn/rcpp/pkg/Rcpp.__Rcheck/tests/Rcpp-unitTests.__html'
            Error in eval(expr, envir, enclos) :
              unit test problems: 1 failures, 0 errors
            Error in checkEquals(__createTwoStringsAsFactors(), DF, msg
        = "DataFrame create2 stringsAsFactors = false") :   Length
        mismatch: comparison on first 2 componentsComponent 2: 'current'
        is not a factorDataFrame create2 stringsAsFactors = false
            Calls: source -> withVisible -> eval -> eval
            Execution halted

        Does it for you?

    Aah. No it does not.

    This is not supported by the new code:

    DataFrame::create(
                     _["a"] = v,
                     _["b"] = s,
                     _["stringsAsFactors"] = false );

    I forgot that we support this and ran the tests just before making
    that change.

    Do we really need this feature ?

    --
    Romain Francois
    Professional R Enthusiast
    +33(0) 6 28 91 30 30 <tel:%2B33%280%29%206%2028%2091%2030%2030>

    R Graph Gallery: http://gallery.r-enthusiasts.__com
    <http://gallery.r-enthusiasts.com>

    blog: http://blog.r-enthusiasts.com
    |- http://bit.ly/ZTFLDo : Simpler R help tooltips
    `- http://bit.ly/YFsziW : R Help tooltips

    _________________________________________________
    Rcpp-devel mailing list
    Rcpp-devel at lists.r-forge.r-__project.org
    <mailto:Rcpp-devel at lists.r-forge.r-project.org>
    https://lists.r-forge.r-__project.org/cgi-bin/mailman/__listinfo/rcpp-devel
    <https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/rcpp-devel>

Romain Francois
Professional R Enthusiast
+33(0) 6 28 91 30 30

R Graph Gallery: http://gallery.r-enthusiasts.com

blog:            http://blog.r-enthusiasts.com
|- http://bit.ly/ZTFLDo : Simpler R help tooltips
`- http://bit.ly/YFsziW : R Help tooltips
Le 02/04/13 17:33, Dirk Eddelbuettel a ?crit :
On 2 April 2013 at 17:16, Romain Francois wrote:
| Do we really need this feature ?

I like to maintain existing APIs and interfaces.

I haven't had time to look at how you now impletement the DataFrame ctor via
List -- but is there no way to catch that stringsAsFactor yes/no choice and
accomidate it?

This choice strikes me as a pretty central feature at the R side of things.

Dirk
Should be back to normal now.
Romain Francois
Professional R Enthusiast
+33(0) 6 28 91 30 30

R Graph Gallery: http://gallery.r-enthusiasts.com

blog:            http://blog.r-enthusiasts.com
|- http://bit.ly/ZTFLDo : Simpler R help tooltips
`- http://bit.ly/YFsziW : R Help tooltips
| Should be back to normal now.

Indeed, looks good -- thanks a bunch!

Dirk
Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com